Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post PrettyTables.jl housekeeping #2525

Open
bkamins opened this issue Nov 8, 2020 · 4 comments
Open

Post PrettyTables.jl housekeeping #2525

bkamins opened this issue Nov 8, 2020 · 4 comments
Milestone

Comments

@bkamins
Copy link
Member

bkamins commented Nov 8, 2020

@ronisbr - I open this issue to keep track of to-do related to PrettyTables.jl:

  1. coverage of show.jl is quite poor now: https://codecov.io/gh/JuliaData/DataFrames.jl/tree/master/src/abstractdataframe; it would be great to add more tests at some point (this point should be reviewed after update manual and docstrings to PrettyTables.jl #2522 is merged as I did some clean up there)
  2. add section in the manual on configuring PrettyTables.jl
  3. add HTML and LaTeX backends
@ronisbr
Copy link
Member

ronisbr commented Nov 8, 2020

Good!

Just one question about 1: maybe I am mistaken, but the code snippets that are not tested seem to be related to the old printing mechanism, which are not used anymore. Am I wrong? The only line that is not tested in _show is the one that blocks floating point alignment if we have more than 200,000 cells.

@bkamins
Copy link
Member Author

bkamins commented Nov 8, 2020

Am I wrong?

That is why I say that we should wait for #2522 as it removes them (and then probably it will be clean).

Still I think we do not have custom PrettyTalbles.jl kwarg tests (I assume that when manual entry is written it can be also used as additional tests).

@ronisbr
Copy link
Member

ronisbr commented Nov 8, 2020

Oh sorry, I am a bit lazy today 😊 Yes, we definitely should add tests with custom options of PrettyTables (at least the most common);

@bkamins bkamins mentioned this issue Nov 14, 2020
20 tasks
@bkamins
Copy link
Member Author

bkamins commented Nov 15, 2020

PRs like #2542 show that it would be good to go back to this housekeeping issue at some moment (no rush - as probably everyone needs a break now 😄; I am updating tutorials).

@bkamins bkamins mentioned this issue Mar 4, 2021
19 tasks
@bkamins bkamins modified the milestones: 1.0, 1.x Mar 25, 2021
@bkamins bkamins modified the milestones: 1.x, 1.5 Sep 13, 2022
@bkamins bkamins modified the milestones: 1.5, 1.6 Feb 5, 2023
@bkamins bkamins modified the milestones: 1.6, 1.7 Jul 10, 2023
@bkamins bkamins modified the milestones: 1.7, 1.x Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants