Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding viewsource and sourceindices functions #2371

Open
bkamins opened this issue Aug 16, 2020 · 0 comments
Open

Consider adding viewsource and sourceindices functions #2371

bkamins opened this issue Aug 16, 2020 · 0 comments
Labels
decision feature non-breaking The proposed change is not breaking
Milestone

Comments

@bkamins
Copy link
Member

bkamins commented Aug 16, 2020

This is a follow up from discussion in #2325 to keep track of it.

parent and parentindices applied on SubDataFrame or DataFrameRow give indices in the data frame that actually stores data that the view points to (currently it is only DataFrame). This is the same behaviour as is in Julia Base.

However, for data frames it might be useful to also produce viewsource and sourceindices that gives the same information but for a direct source from which SubDataFrame or DataFrameRow was created (similarly to what rownumber does for DataFrameRow).

Adding this would complicate a design a bit and at lest I believe that it is not really needed (there were no requests for such functionality; as opposed to rownumber which I believe is useful). Therefore I leave this issue open to discuss and get feedback if this functionality is needed.

@bkamins bkamins added decision feature non-breaking The proposed change is not breaking labels Aug 16, 2020
@bkamins bkamins added this to the 1.x milestone Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision feature non-breaking The proposed change is not breaking
Projects
None yet
Development

No branches or pull requests

1 participant