Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fast sha2 to julia stdlib #58

Closed
gdkrmr opened this issue Sep 1, 2018 · 3 comments
Closed

add fast sha2 to julia stdlib #58

gdkrmr opened this issue Sep 1, 2018 · 3 comments

Comments

@gdkrmr
Copy link
Contributor

gdkrmr commented Sep 1, 2018

@staticfloat, now that the stress of the 1.0 release has passed, please don't forget to add the fast sha2 implementation to the SHA version in Stdlib.

@staticfloat
Copy link
Member

@KristofferC what's the best way to get improvements from SHA.jl merged into stdlib?

@KristofferC
Copy link
Contributor

Could do the whole git-external for SHA?

In hindsight, it is a bit silly that SHA is in the stdlib because it is used in one place (https://github.com/JuliaLang/Pkg.jl/blob/87eb9343dd3523d4be23c9c474b9708af3bcb456/src/Types.jl#L42) and only at compile time.

@staticfloat
Copy link
Member

And with JuliaLang/julia#41370 we've finally come full circle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants