MD5

[jw3126]

I have a md5 implementation here. It uses the same structure as SHA.jl and I copy pasted some SHA.jl code there. This is not ideal, I can think of a couple of other options:

• Merge MD5.jl into SHA.jl
• Create some HashFunctionsBase.jl package with common code
• Let MD5.jl depend on SHA.jl

What do you think @staticfloat ?

[oxinabox]

Hah, we actually did this at the same time (like to the hour I think).
See: https://github.com/oxinabox/MD5.jl
#46

I did the "Let MD5.jl depend on SHA.jl"

[jw3126]

Did you look at the performance? I got rid of all branches in tranform!, but libnettle is still twice as fast.

[oxinabox]

I did not.
Yours looks more performant than mine.
I wanted to get it done with minimum code.

I think the most performant (and also cleanest) would be somewhere between the two.
It'll take some tweaking to find.

[jw3126]

We can discuss it here JuliaCrypto/MD5.jl#2

[staticfloat]

Just FYI, there is a new JuliaCrypto organization that we're starting to collect packages underneath.

[jw3126]

@oxinabox shall we move MD5 to JuliaCrypto?

[oxinabox]

We should, but I can't seem to find my invite. @ViralBShah are you sure you sent the invite to the org right?

[ViralBShah]

Yeah shows me as pending. Maybe check your spam? Is there a way to see on GitHub itself?

[oxinabox]

Ah, if i go to the org page myself I can see it.
Sorted

[oxinabox]

Done
https://github.com/JuliaCrypto/MD5.jl