Set the number of BLAS threads to 2. #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed this on the call, and we decided to set the number of threads to 2 everywhere. That should solve our memory issues, and also exercise multithreading paths. |
DilumAluthge
force-pushed
the
gb/windows-blas
branch
from
34ba4f1
to
ab002e9
Compare
|
Is this good to merge? |
|
Can you update the PR title to reflect the final contents of the PR? |
gbaraldi
changed the title
|
Don't merge this yet; I think Kristoffer and I have found that we are actually only supposed to be using one thread on CI. I think we need to solve the timing issue in Distributed's setting of threads, first. |
|
So distributed should be passing the number of threads as 1 already? But doesn't? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an experiment, I set the blas threads to 1, and enable threads on the matmul testset.
Ref #239
Edit:
Set BLAS threads to 2 to reduce change of OOM on windows and reduce contention