Replace AbstractTriangular by union #1146
Conversation
mateuszbaran
left a comment
mateuszbaran
left a comment
There was a problem hiding this comment.
This looks fine to me but I will wait with merging a couple of days to let people comment on this. I think people should just move to StaticArrays.jl at this point, I haven't seen a good reason not to. I guess the packages stuck on StaticArrays.jl 0.12 are just no longer maintained?
|
Perhaps we should include Julia v1.6 in CI on this branch. |
|
Yes, sure, adding Julia 1.6 to CI here is a good idea. |
|
Hm, it looks like a bit more needs to get backported to make the tests running on newer Julia versions. BTW, I'd still like to keep testing on Julia 1.0 on this branch. |
|
Honestly, I think we should just merge and release. The last pre-v1 version of this package has 53 ambiguities, this PR has only 52 (at least locally). Packages that are bound to <v1 of StaticArrays.jl already need to live with those 53 ambiguities on Julia v1.6 (and perhaps beyond). The way how to resolve the ambiguities is to bump the compat restriction. I can adjust the failing test for this branch to have green CI. |
|
Boy, independently from the original intention here, there are a lot of tests that need adoption. I'll shout when this is done. |
|
Hm, another option could be to release a v0.12.6 with a Julia compat bounded from above by |
|
Hm, yes, this doesn't look good.
As far as I can see, this doesn't solve any problem because it won't un-block changing
Probably just opening issues on github or writing e-mails to maintainers? This would really be the best solution but I doubt all of these packages are still actively maintained. |
|
Boy, this is so broken (in terms of functionality, it can still be loaded though)... and apparently, the packages that are still stuck on pre-v1 don't need any of the broken functionality, so they don't see it. I think this can be merged and released now. |
|
That's indeed quite a few broken things. Let's release it though and see what happens. |
2 participants
The diff looks exactly like it should. This PR backports some minor changes to the pre-1.0 series, at which many packages are still stuck because of old compat restrictions. I'm convinced, however, that most if not all could bump their compat restriction to v1.x. Without that bump, however, all these packages will stop working on Julia v1.10, after JuliaLang/julia#26307 is merged.
Before we merge this, let's wait for a confirmation that we're on the right track.