Skip to content

Conversation

@dkarrasch
Copy link
Contributor

@dkarrasch dkarrasch commented Mar 14, 2023

This is in preparation of #26307. Especially when type parameters are used, I believe that the union of the four *Triangular types is actually meant.

For simplicity, I have copied the aliases from current LinearAlgebra to avoid VERSION-dependent code. I could add a note that these definitions could be removed once the lower compat is raised to v1.10, if desired.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #217 (ca85f94) into master (3c12489) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files           4        4           
  Lines         656      656           
=======================================
  Hits          650      650           
  Misses          6        6           
Impacted Files Coverage Δ
src/FillArrays.jl 99.69% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dkarrasch
Copy link
Contributor Author

That's strange. On master, checksquare is not imported, and not used in my PR. How come it gets added when you merge master into this branch? It doesn't matter, of course, but still strange.

@jishnub
Copy link
Member

jishnub commented Mar 15, 2023

checksquare is imported on master in 3c12489

@dkarrasch
Copy link
Contributor Author

I see, I missed the revert-and-resubmission.

@dlfivefifty dlfivefifty merged commit 97862c5 into JuliaArrays:master Mar 15, 2023
@dkarrasch dkarrasch deleted the patch-1 branch March 15, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants