-
Notifications
You must be signed in to change notification settings - Fork 40
map
and mapreduce
#146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
map
and mapreduce
#146
Conversation
Error on 1.0 was real, "UndefVarError: _InitialValue not defined". I've just disabled these methods on old versions, rather than try to figure out how 1.0 did this & exactly when the change happened. Without them you will more often get an Array, as you do without this PR. |
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
+ Coverage 95.66% 95.97% +0.31%
==========================================
Files 4 4
Lines 531 572 +41
==========================================
+ Hits 508 549 +41
Misses 23 23
Continue to review full report at Codecov.
|
Tests are failing on 1.0 |
Oh right, sorry, looks like vararg |
Bump? |
Great if you bump the version number I can tag a new release |
Can do, or else #144 has a version bump, too. |
This should make
map(f, A, B, C)
, andmapreduce(f, op, A, B, C)
work for FillArrays.One motivation is that Base's
mapreduce
isn't fast for multiple arrays, but if we peel off the ones which areFill
then we can go the fast path. The other is that a mix of CuArrays & Fill seems to give errors:Edit -- scope has crept a little, it now also handles
reduce
, which has this result:Happy to remove / separate that if you prefer.