Fix getindex of Fill with Trues in N-D (#151)

* 150 v1

* clean

* Update src/trues.jl

Co-authored-by: Sheehan Olver <solver@mac.com>

* Update src/trues.jl

Co-authored-by: Sheehan Olver <solver@mac.com>

Co-authored-by: Sheehan Olver <solver@mac.com>

Author: JeffFessler

Project.toml

@@ -1,6 +1,6 @@
 name = "FillArrays"
 uuid = "1a297f60-69ca-5386-bcde-b61e274b549b"
-version = "0.11.8"
+version = "0.11.9"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

src/trues.jl

@@ -44,10 +44,11 @@ function Base.getindex(x::AbstractArray{T,N}, mask::Trues{N, NTuple{N,Base.OneTo
     return x[trues(size(x))] # else revert to usual getindex method
 end
 
-# https://github.com/JuliaArrays/FillArrays.jl/issues/148
+# https://github.com/JuliaArrays/FillArrays.jl/issues/148 and 150
 function Base.getindex(
-    a::AbstractFill{T, 1, Tuple{Base.OneTo{Int}}},
-    b::Trues{1, Tuple{Base.OneTo{Int}}}) where T
-    @boundscheck length(a) == length(b) || throw(BoundsError(a, b))
+    a::AbstractFill{T, N, Tuple{Vararg{Base.OneTo{Int}, N}}},
+    b::Trues{N, Tuple{Vararg{Base.OneTo{Int}, N}}},
+) where {T, N}
+    @boundscheck size(a) == size(b) || throw(BoundsError(a, b))
     return Fill(getindex_value(a), length(a))
 end

test/runtests.jl

@@ -1206,6 +1206,9 @@ end
     @test_throws DimensionMismatch setindex!(ones(2), zeros(3), Trues(2))
     @test Ones(3)[Trues(3)] == Ones(3)
     @test_throws BoundsError Ones(3)[Trues(2)]
+    @test Ones(2,3)[Trues(2,3)] == Ones(6)
+    @test Ones(2,3)[Trues(6)] == Ones(6)
+    @test_throws BoundsError Ones(2,3)[Trues(3,2)]
 end
 
 @testset "FillArray interface" begin