Integrate ArrayInterface #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 90.14% 89.53% -0.61%
==========================================
Files 7 7
Lines 710 717 +7
==========================================
+ Hits 640 642 +2
- Misses 70 75 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dependency on ArrayInterface supporting common methods for extracting dimension names and the stride layout interface that LoopVectorization depends on.
There are plans to provide a common method for what equates to
Axis.val, but that will require more discussion before being merged into ArrayInterface (see JuliaArrays/ArrayInterface.jl#328 and JuliaArrays/ArrayInterface.jl#250)