Add conversion for integer for FITS data#2
Open
ptiede wants to merge 2 commits into
Open
Conversation
Member
|
thanks for catching the edgecase! |
Author
|
Maybe? This was some private GMVA data that was shared with me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up at the Comrade HOPS workshop. It seems like CASA's save data is storing something related to the antennas as an integer instead of a float, which is causing the file to not be parsed. Now, this should probably be fixed upstream in rPicard if it doesn't follow the FITS standard, but in the meantime, this will allow people to actually read that data.