chore: dont throw on prompt scorer get

Author: abhishekg999

judgeval-java/src/main/java/com/judgmentlabs/judgeval/v1/data/APIScorerType.java

@@ -9,9 +9,6 @@ public enum APIScorerType {
     FAITHFULNESS("Faithfulness"),
     ANSWER_RELEVANCY("Answer Relevancy"),
     ANSWER_CORRECTNESS("Answer Correctness"),
-    INSTRUCTION_ADHERENCE("Instruction Adherence"),
-    EXECUTION_ORDER("Execution Order"),
-    DERAILMENT("Derailment"),
     CUSTOM("Custom");
 
     private final String value;

judgeval-java/src/main/java/com/judgmentlabs/judgeval/v1/scorers/built_in/AnswerCorrectnessScorer.java

@@ -40,7 +40,7 @@ public static Builder builder() {
      * Builder for configuring and creating AnswerCorrectnessScorer instances.
      */
     public static final class Builder {
-        private double  threshold = -1;
+        private double  threshold = 0.5;
         private String  name;
         private Boolean strictMode;
         private String  model;

judgeval-java/src/main/java/com/judgmentlabs/judgeval/v1/scorers/built_in/AnswerRelevancyScorer.java

@@ -39,7 +39,7 @@ public static Builder builder() {
      * Builder for configuring and creating AnswerRelevancyScorer instances.
      */
     public static final class Builder {
-        private double  threshold = -1;
+        private double  threshold = 0.5;
         private String  name;
         private Boolean strictMode;
         private String  model;

judgeval-java/src/main/java/com/judgmentlabs/judgeval/v1/scorers/built_in/BuiltInScorersFactory.java

@@ -33,13 +33,4 @@ public AnswerRelevancyScorer.Builder answerRelevancy() {
     public FaithfulnessScorer.Builder faithfulness() {
         return FaithfulnessScorer.builder();
     }
-
-    /**
-     * Creates a builder for an instruction adherence scorer.
-     *
-     * @return the scorer builder
-     */
-    public InstructionAdherenceScorer.Builder instructionAdherence() {
-        return InstructionAdherenceScorer.builder();
-    }
 }

judgeval-java/src/main/java/com/judgmentlabs/judgeval/v1/scorers/built_in/FaithfulnessScorer.java

@@ -39,7 +39,7 @@ public static Builder builder() {
      * Builder for configuring and creating FaithfulnessScorer instances.
      */
     public static final class Builder {
-        private double  threshold = -1;
+        private double  threshold = 0.5;
         private String  name;
         private Boolean strictMode;
         private String  model;

judgeval-java/src/main/java/com/judgmentlabs/judgeval/v1/scorers/built_in/InstructionAdherenceScorer.java

@@ -6,13 +6,13 @@
 import java.util.Optional;
 import java.util.concurrent.ConcurrentHashMap;
 
-import com.judgmentlabs.judgeval.exceptions.JudgmentAPIError;
 import com.judgmentlabs.judgeval.internal.api.JudgmentSyncClient;
 import com.judgmentlabs.judgeval.internal.api.models.FetchPromptScorersRequest;
 import com.judgmentlabs.judgeval.internal.api.models.FetchPromptScorersResponse;
+import com.judgmentlabs.judgeval.utils.Logger;
 
 /**
- * Factory for retrieving and creating prompt-based scorers.
+ * Factory for retrieving prompt-based scorers.
  */
 public final class PromptScorerFactory {
     private final JudgmentSyncClient                                                               client;
@@ -30,9 +30,7 @@ public PromptScorerFactory(JudgmentSyncClient client, boolean isTrace) {
      *
      * @param name
      *            the scorer name
-     * @return the configured prompt scorer
-     * @throws JudgmentAPIError
-     *             if the scorer is not found or retrieval fails
+     * @return the configured prompt scorer or null if not found or retrieval fails
      */
     public PromptScorer get(String name) {
         CacheKey key = new CacheKey(name, client.getApiKey(), client.getOrganizationId());
@@ -51,22 +49,28 @@ public PromptScorer get(String name) {
                     .map(FetchPromptScorersResponse::getScorers)
                     .filter(scorers -> scorers != null && !scorers.isEmpty())
                     .map(scorers -> scorers.get(0))
-                    .orElseThrow(
-                            () -> new JudgmentAPIError(404, "Failed to fetch prompt scorer '" + name + "': not found"));
+                    .orElseGet(
+                            () -> {
+                                Logger.error("Failed to fetch prompt scorer '" + name + "': not found");
+                                return null;
+                            });
+
+            if (scorer == null) {
+                return null;
+            }
 
             if (Boolean.TRUE.equals(scorer.getIsTrace()) != isTrace) {
-                String expectedType = isTrace ? "TracePromptScorer" : "PromptScorer";
-                String actualType = Boolean.TRUE.equals(scorer.getIsTrace()) ? "TracePromptScorer" : "PromptScorer";
-                throw new JudgmentAPIError(400,
-                        "Scorer with name " + name + " is a " + actualType + ", not a " + expectedType);
+                Logger.error("Scorer with name " + name + " is a "
+                        + (Boolean.TRUE.equals(scorer.getIsTrace()) ? "TracePromptScorer" : "PromptScorer") + ", not a "
+                        + (isTrace ? "TracePromptScorer" : "PromptScorer"));
+                return null;
             }
 
             cache.put(key, scorer);
             return createFromModel(scorer, name);
-        } catch (JudgmentAPIError e) {
-            throw e;
         } catch (Exception e) {
-            throw new JudgmentAPIError(500, "Failed to fetch prompt scorer '" + name + "': " + e.getMessage());
+            Logger.error("Failed to fetch prompt scorer '" + name + "': " + e.getMessage());
+            return null;
         }
     }
 
@@ -95,16 +99,6 @@ private PromptScorer createFromModel(com.judgmentlabs.judgeval.internal.api.mode
                 .build();
     }
 
-    /**
-     * Creates a new prompt scorer builder.
-     *
-     * @return a new scorer builder
-     */
-    public PromptScorer.Builder create() {
-        return PromptScorer.builder()
-                .isTrace(isTrace);
-    }
-
     private static final class CacheKey {
         private final String name;
         private final String apiKey;

judgeval-java/src/main/java/com/judgmentlabs/judgeval/v1/scorers/prompt_scorer/PromptScorerFactory.java

@@ -30,10 +30,4 @@ void faithfulness_returnsBuilder() {
         FaithfulnessScorer.Builder builder = factory.faithfulness();
         assertNotNull(builder);
     }
-
-    @Test
-    void instructionAdherence_returnsBuilder() {
-        InstructionAdherenceScorer.Builder builder = factory.instructionAdherence();
-        assertNotNull(builder);
-    }
 }