Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Type snapshots can't infer ESLint fix mode without a process.argv --fix #115

Open
3 tasks done
JoshuaKGoldberg opened this issue Dec 19, 2023 · 2 comments
Open
3 tasks done

🐛 Bug: Type snapshots can't infer ESLint fix mode without a process.argv --fix #115

JoshuaKGoldberg opened this issue Dec 19, 2023 · 2 comments
Labels
status: blocked Waiting for something else to be resolved type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

As originally reported by #14: type snapshots should update if ESLint is run in --fix mode. For a while they were always being updated (unless disableExpectTypeSnapshotFix was enabled).

Actual

As of #113, type snapshots are only updated if process.argv.includes('--fix'). That doesn't account for programmatic usage of ESLint's Node.js API such as from an editor extension.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: blocked Waiting for something else to be resolved labels Dec 19, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 19, 2023
Open
1 task
@coderaiser

This comment was marked as off-topic.

Sign in to view
@JoshuaKGoldberg

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: blocked Waiting for something else to be resolved type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coderaiser @JoshuaKGoldberg