Skip to content

feat: allowed hydration directory to be empty #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Changes split out of #668:

  • If git status fails, runs git init to make the directory a repo
  • Allows package.json to be empty, defaulting its contents to {}

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #673 (3cf6331) into main (7cba114) will increase coverage by 0.38%.
Report is 3 commits behind head on main.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   49.87%   50.25%   +0.38%     
==========================================
  Files          63       64       +1     
  Lines         389      396       +7     
  Branches       75       76       +1     
==========================================
+ Hits          194      199       +5     
- Misses        185      186       +1     
- Partials       10       11       +1     
Flag Coverage Δ
hydrate 100.00% <ø> (ø)
setup ∅ <ø> (∅)
unit 49.74% <75.00%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/hydrate/index.ts 0.00% <ø> (ø)
src/hydrate/steps/finalizeDependencies.ts 100.00% <ø> (ø)
...hydrate/steps/writing/creation/writePackageJson.ts 88.88% <0.00%> (-11.12%) ⬇️
src/setup/steps/updateAllContributorsTable.ts 0.00% <0.00%> (ø)
src/shared/getDefaultSettings.ts 100.00% <ø> (ø)
src/shared/ensureGitRepository.ts 100.00% <100.00%> (ø)
src/shared/runOrRestore.ts 88.88% <100.00%> (+0.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 597e6da into main Aug 21, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the allow-empty-directory branch August 21, 2023 19:25
@github-actions
Copy link

🎉 This is included in version v1.28.56 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Allow hydration/migration to run on an empty directory
1 participant