security analysis

Author: JoshuaEstes

.github/workflows/static-analysis.yml

@@ -36,21 +36,6 @@ jobs:
                   coverage: none
             - run: make composer-install psalm-install
             - run: make psalm-github
-
-    psalm-security:
-        name: Psalm (Security)
-        runs-on: ubuntu-latest
-        steps:
-            - uses: actions/checkout@v3
-            - uses: shivammathur/setup-php@v2
-              with:
-                  php-version: '8.1'
-                  coverage: none
-            - name: Psalm
-              uses: docker://vimeo/psalm-github-actions
-              with:
-                  security_analysis: true
-                  report_file: results.sarif
             - name: Upload Security Analysis to Github
               uses: github/codeql-action/upload-sarif@v1
               with:

.gitignore

@@ -8,3 +8,4 @@ phpunit.xml
 composer.phar
 /packages.json
 /.phpunit
+/results.sarif

Makefile

@@ -59,7 +59,7 @@ psalm-baseline: # Updates the baseline file
 	XDEBUG_MODE=off $(PHP) -dxdebug.mode=off $(PSALM) --update-baseline --set-baseline=$(PSALM_BASELINE_FILE)
 
 psalm-github: # used with GitHub
-	XDEBUG_MODE=off $(PHP) -dxdebug.mode=off $(PSALM) --long-progress --monochrome --output-format=github
+	XDEBUG_MODE=off $(PHP) -dxdebug.mode=off $(PSALM) --long-progress --monochrome --output-format=github --report=results.sarif
 
 psalm-install:
 	XDEBUG_MODE=off $(COMPOSER) install --working-dir=tools/psalm --no-interaction --prefer-dist --optimize-autoloader