Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Sending to an address inside bitcoin core wallet crashes #501

Open
chris-belcher opened this issue Apr 21, 2016 · 0 comments
Open

Sending to an address inside bitcoin core wallet crashes #501

chris-belcher opened this issue Apr 21, 2016 · 0 comments

Comments

@chris-belcher
Copy link
Collaborator

Because of this line:

https://github.com/JoinMarket-Org/joinmarket/blob/develop/joinmarket/blockchaininterface.py#L650

getaccounts returns "" when the address isnt contained, but also if the address is in the account "".

If importaddress tries to add an address which is already in there, it seems to crash (TODO check this)

One way to work around this is to surround the importaddress with a try: except JsonRpcError: in python, but that would swallow other errors too.

Another way is to use listaccounts to get all the account names, then getaddressesbyaccount to get all the addresses. This might be slow and overkill, but is probably the only other way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant