You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 13, 2022. It is now read-only.
When a keypair is created, sign and verify something to check the key generation has worked. The hash can be anything, random data or even a constant.
Put this in get_new_address() probably.
Will slow it down slightly (not by much) and it will only be noticeable for wallet-tool.py, but its worth it.
It's not just a hypothetical concern, in the bitcoin ecosystem it's happened several times that a wallet incorrectly generated the pubkey and send user's funds into space.
in bitcoin core we always use a newly generated key to sign and verify the signature to double check the generation. (in case the users computer glitches or the software screws up)
If it fails, then crash and create a file "DO_NOT_REMOVE_THIS_FILE_UNTIL_YOU_HAVE_VERIFIED_YOUR_HARDWARE_IS_NOT_BROKEN", and then refuse to start again with a polite message.
The text was updated successfully, but these errors were encountered:
When a keypair is created, sign and verify something to check the key generation has worked. The hash can be anything, random data or even a constant.
Put this in get_new_address() probably.
Will slow it down slightly (not by much) and it will only be noticeable for wallet-tool.py, but its worth it.
It's not just a hypothetical concern, in the bitcoin ecosystem it's happened several times that a wallet incorrectly generated the pubkey and send user's funds into space.
in bitcoin core we always use a newly generated key to sign and verify the signature to double check the generation. (in case the users computer glitches or the software screws up)
If it fails, then crash and create a file "DO_NOT_REMOVE_THIS_FILE_UNTIL_YOU_HAVE_VERIFIED_YOUR_HARDWARE_IS_NOT_BROKEN", and then refuse to start again with a polite message.
The text was updated successfully, but these errors were encountered: