Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joinmarket depends on openssl 1.1.x through python-bitcointx #1613

Closed
erikarvstedt opened this issue Dec 2, 2023 · 4 comments
Closed

Joinmarket depends on openssl 1.1.x through python-bitcointx #1613

erikarvstedt opened this issue Dec 2, 2023 · 4 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@erikarvstedt
Copy link
Contributor

jmbitcoin requires python-bitcointx 1.1.3 which requires openssl 1.1.x.

openssl 1.1.x has reached EOL on 2023-09-11 (https://www.openssl.org/blog/blog/2023/03/28/1.1.1-EOL). This may be a security issue.

Newer, unreleased versions of python-bitcointx run without openssl.

@kristapsk kristapsk added the dependencies Pull requests that update a dependency file label Dec 2, 2023
@kristapsk
Copy link
Member

Newer, unreleased versions of python-bitcointx run without openssl.

New release of python-bitcointx waits on user feedback, see Simplexum/python-bitcointx#75 (there is link to branch in conversation) and #1515. Testing these and giving feedback would help.

@kristapsk
Copy link
Member

@erikarvstedt #1515 is likely soon to be merged, should solve this. Testing / review would not hurt.

@AdamISZ
Copy link
Member

AdamISZ commented Dec 9, 2023

Ah cool, 1.1.4 is released now ( https://github.com/Simplexum/python-bitcointx/releases/tag/python-bitcointx-v1.1.4 ).

Also this means we can use the full taproot support (except maybe PSBT stuff? not sure, need to check). Just for future reference.

@kristapsk
Copy link
Member

Ah cool, 1.1.4 is released now ( https://github.com/Simplexum/python-bitcointx/releases/tag/python-bitcointx-v1.1.4 ).

Also this means we can use the full taproot support (except maybe PSBT stuff? not sure, need to check). Just for future reference.

Yes, #1515 (comment), need to review / test that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants