Skip to content

Commit

Permalink
Rollup merge of rust-lang#65007 - BO41:keywords, r=nikomatsakis
Browse files Browse the repository at this point in the history
Mention keyword closing policy

closes rust-lang#59233 / rust-lang#59233 (comment)

rewording suggestions welcome

> Also in the referenced issue, the commit number of the new commit
> that could close that issue is not really informative. The PR number itself appeared in the issue
> is more informative and concise.

@lzutao what do you mean with that? Is this fixed by the new "May be fixed by #XXXXX"?
  • Loading branch information
JohnTitor authored Oct 23, 2019
2 parents 8699227 + 1c85b45 commit bd82de0
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,14 @@ the master branch to your feature branch.
Also, please make sure that fixup commits are squashed into other related
commits with meaningful commit messages.

GitHub allows [closing issues using keywords][closing-keywords]. This feature
should be used to keep the issue tracker tidy. However, it is generally preferred
to put the "closes #123" text in the PR description rather than the issue commit;
particularly during rebasing, citing the issue number in the commit can "spam"
the issue in question.

[closing-keywords]: https://help.github.com/en/articles/closing-issues-using-keywords

Please make sure your pull request is in compliance with Rust's style
guidelines by running

Expand Down

0 comments on commit bd82de0

Please sign in to comment.