Skip to content

Sparknlp 1115 Introducing SmolVLM #14552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

prabod
Copy link
Contributor

@prabod prabod commented Apr 14, 2025

Description

This PR introduces SmolVLM by huggingface

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

prabod added 8 commits March 31, 2025 11:14
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
@prabod prabod added on-hold cannot be merged right away new-feature Introducing a new feature DON'T MERGE Do not merge this PR labels Apr 14, 2025
@prabod prabod requested a review from maziyarpanahi April 14, 2025 11:29
@prabod prabod self-assigned this Apr 14, 2025
@DevinTDHa DevinTDHa changed the base branch from master to release/601-release-candidate May 6, 2025 12:28
@DevinTDHa DevinTDHa self-requested a review May 6, 2025 14:23
prabod added 3 commits May 12, 2025 05:45
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
@prabod prabod requested a review from DevinTDHa May 12, 2025 05:51
Copy link
Member

@DevinTDHa DevinTDHa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits, looks good to me!

@DevinTDHa DevinTDHa merged commit 264d8e7 into release/601-release-candidate May 12, 2025
1 of 4 checks passed
@DevinTDHa DevinTDHa mentioned this pull request May 12, 2025
10 tasks
DevinTDHa pushed a commit that referenced this pull request May 14, 2025
* smolvlm utils

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

* add smolvlm image preprocess

* added scala api

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

* added scala API and python API

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

* documentation

* update default model

* add notebook

* add resource downloader

* revert the changes to BPE tokenizer and move changes to SmolVLMTokenizer

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

* removed configProtoBytes as we do not support TF for this model

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

* remove images in openvino notebook dir

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

---------

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
DevinTDHa pushed a commit that referenced this pull request May 28, 2025
* smolvlm utils

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

* add smolvlm image preprocess

* added scala api

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

* added scala API and python API

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

* documentation

* update default model

* add notebook

* add resource downloader

* revert the changes to BPE tokenizer and move changes to SmolVLMTokenizer

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

* removed configProtoBytes as we do not support TF for this model

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

* remove images in openvino notebook dir

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>

---------

Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
DevinTDHa added a commit that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DON'T MERGE Do not merge this PR new-feature Introducing a new feature on-hold cannot be merged right away
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants