-
Notifications
You must be signed in to change notification settings - Fork 727
Sparknlp 1115 Introducing SmolVLM #14552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DevinTDHa
merged 11 commits into
release/601-release-candidate
from
SPARKNLP-1115-Implement-SmolVLM-from-Huggingface
May 12, 2025
Merged
Sparknlp 1115 Introducing SmolVLM #14552
DevinTDHa
merged 11 commits into
release/601-release-candidate
from
SPARKNLP-1115-Implement-SmolVLM-from-Huggingface
May 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
DevinTDHa
requested changes
May 7, 2025
src/main/scala/com/johnsnowlabs/nlp/annotators/tokenizer/bpe/BpeTokenizer.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
DevinTDHa
approved these changes
May 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edits, looks good to me!
264d8e7
into
release/601-release-candidate
1 of 4 checks passed
DevinTDHa
pushed a commit
that referenced
this pull request
May 14, 2025
* smolvlm utils Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> * add smolvlm image preprocess * added scala api Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> * added scala API and python API Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> * documentation * update default model * add notebook * add resource downloader * revert the changes to BPE tokenizer and move changes to SmolVLMTokenizer Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> * removed configProtoBytes as we do not support TF for this model Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> * remove images in openvino notebook dir Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> --------- Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
DevinTDHa
pushed a commit
that referenced
this pull request
May 28, 2025
* smolvlm utils Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> * add smolvlm image preprocess * added scala api Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> * added scala API and python API Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> * documentation * update default model * add notebook * add resource downloader * revert the changes to BPE tokenizer and move changes to SmolVLMTokenizer Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> * removed configProtoBytes as we do not support TF for this model Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> * remove images in openvino notebook dir Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me> --------- Signed-off-by: Prabod Rathnayaka <prabod@rathnayaka.me>
DevinTDHa
added a commit
that referenced
this pull request
May 28, 2025
This reverts commit fe183a3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DON'T MERGE
Do not merge this PR
new-feature
Introducing a new feature
on-hold
cannot be merged right away
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces SmolVLM by huggingface
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: