More uses of AUDACITY_DLL_API...

... in many places where the function call will later need to be between
modules (or libraries, or the executable) and the annotation will be a necessity
to keep the linkage working on Windows.

That's all that this sweeping commit does.

Author: Paul-Licameli

images/Cursors.h

@@ -30,4 +30,5 @@
 #endif
 #include "Cursors32/SubViewsCursor.xpm"
 
+AUDACITY_DLL_API
 std::unique_ptr<wxCursor> MakeCursor(int WXUNUSED(CursorId), const char * const pXpm[36], int HotX, int HotY);

include/audacity/PluginInterface.h

@@ -51,7 +51,7 @@
 class ModuleInterface;
 
 
-class PluginManagerInterface /* not final */
+class AUDACITY_DLL_API PluginManagerInterface /* not final */
 {
 public:
 

include/audacity/Types.h

@@ -287,7 +287,7 @@ using CommandIDs = std::vector<CommandID>;
 // The msgid should be used only in unusual cases and the translation more often
 //
 // Implicit conversions to and from wxString are intentionally disabled
-class TranslatableString {
+class AUDACITY_DLL_API TranslatableString {
    enum class Request;
    template< size_t N > struct PluralTemp;
 

src/AColor.h

@@ -22,7 +22,7 @@ class wxDC;
 class wxGraphicsContext;
 class wxRect;
 
-class AColor {
+class AUDACITY_DLL_API AColor {
  public:
 
     enum ColorGradientChoice {

src/AboutDialog.h

@@ -29,7 +29,7 @@ struct AboutDialogCreditItem {
 
 using AboutDialogCreditItemsList = std::vector<AboutDialogCreditItem>;
 
-class AboutDialog final : public wxDialogWrapper {
+class AUDACITY_DLL_API AboutDialog final : public wxDialogWrapper {
    DECLARE_DYNAMIC_CLASS(AboutDialog)
 
  public:

src/AudacityException.h

@@ -45,7 +45,8 @@ class AudacityException /* not final */
 //! Abstract AudacityException subclass displays a message, specified by further subclass
 /*! At most one message will be displayed for each pass through the main event idle loop,
  no matter how many exceptions were caught. */
-class MessageBoxException /* not final */ : public AudacityException
+class AUDACITY_DLL_API MessageBoxException /* not final */
+   : public AudacityException
 {
    //! Privatize the inherited function
    using AudacityException::DelayedHandlerAction;
@@ -74,7 +75,8 @@ class MessageBoxException /* not final */ : public AudacityException
 };
 
 //! A MessageBoxException that shows a given, unvarying string.
-class SimpleMessageBoxException /* not final */ : public MessageBoxException
+class AUDACITY_DLL_API SimpleMessageBoxException /* not final */
+   : public MessageBoxException
 {
 public:
    explicit SimpleMessageBoxException(

src/AudacityLogger.h

@@ -26,7 +26,7 @@
 class wxFrame;
 class wxTextCtrl;
 
-class AudacityLogger final : public wxEvtHandler,
+class AUDACITY_DLL_API AudacityLogger final : public wxEvtHandler,
                              public wxLog,
                              public PrefsListener
 {

src/Benchmark.h

@@ -14,6 +14,7 @@
 class wxWindow;
 class AudacityProject;
 
+AUDACITY_DLL_API
 void RunBenchmark( wxWindow *parent, AudacityProject &project );
 
 #endif // define __AUDACITY_BENCHMARK__

src/ClientData.h

@@ -44,7 +44,7 @@ template< typename Object > using BarePtr = Object*;
  */
 template<
    template<typename> class Owner = UniquePtr
-> struct Cloneable
+> struct AUDACITY_DLL_API Cloneable
 {
    using Base = Cloneable;
    using PointerType = Owner< Base >;

src/Clipboard.h

@@ -23,7 +23,7 @@ class TrackList;
 wxDECLARE_EXPORTED_EVENT( AUDACITY_DLL_API,
                           EVT_CLIPBOARD_CHANGE, wxCommandEvent );
 
-class Clipboard final
+class AUDACITY_DLL_API Clipboard final
    : public wxEvtHandler
 {
 public:

src/CommonCommandFlags.h

@@ -15,10 +15,17 @@ Paul Licameli split from Menus.cpp
 
 #include "commands/CommandFlag.h"
 
+AUDACITY_DLL_API
 bool EditableTracksSelectedPred( const AudacityProject &project );
+
+AUDACITY_DLL_API
 bool AudioIOBusyPred( const AudacityProject &project );
+
+AUDACITY_DLL_API
 bool TimeSelectedPred( const AudacityProject &project );
-extern const CommandFlagOptions &cutCopyOptions();
+
+AUDACITY_DLL_API
+const CommandFlagOptions &cutCopyOptions();
 
 extern AUDACITY_DLL_API const ReservedCommandFlag
    &AudioIONotBusyFlag(),

src/CrashReport.h

@@ -26,6 +26,7 @@
 
    namespace CrashReport
    {
+      AUDACITY_DLL_API
       void Generate(wxDebugReport::Context ctx);
    }
 #endif

src/DBConnection.h

@@ -131,7 +131,7 @@ class DBConnection
     Commit() must not be called again after one successful call.
     An exception is thrown from the constructor if the transaction cannot open.
  */
-class TransactionScope
+class AUDACITY_DLL_API TransactionScope
 {
 public:
    TransactionScope(DBConnection &connection, const char *name);

src/DeviceManager.h

@@ -18,8 +18,6 @@
 #ifndef __AUDACITY_DEVICEMANAGER__
 #define __AUDACITY_DEVICEMANAGER__
 
-
-
 #include <chrono>
 #include <vector>
 
@@ -45,9 +43,10 @@ typedef struct DeviceSourceMap {
    wxString hostString;
 } DeviceSourceMap;
 
+AUDACITY_DLL_API
 wxString MakeDeviceSourceString(const DeviceSourceMap *map);
 
-class DeviceManager final
+class AUDACITY_DLL_API DeviceManager final
 #if defined(EXPERIMENTAL_DEVICE_CHANGE_HANDLER)
 #if defined(HAVE_DEVICE_CHANGE)
 :  public DeviceChangeHandler

src/Dither.h

@@ -25,7 +25,7 @@ class Dither
     static DitherType FastDitherChoice();
     static DitherType BestDitherChoice();
 
-    static EnumSetting< DitherType > FastSetting, BestSetting;
+    static AUDACITY_DLL_API EnumSetting< DitherType > FastSetting, BestSetting;
 
     /// Default constructor
     Dither();

src/Envelope.h

@@ -68,7 +68,7 @@ class EnvPoint final : public XMLTagHandler {
 typedef std::vector<EnvPoint> EnvArray;
 struct TrackPanelDrawingContext;
 
-class Envelope /* not final */ : public XMLTagHandler {
+class AUDACITY_DLL_API Envelope /* not final */ : public XMLTagHandler {
 public:
    // Envelope can define a piecewise linear function, or piecewise exponential.
    Envelope(bool exponential, double minValue, double maxValue, double defaultValue);

src/EnvelopeEditor.h

@@ -19,7 +19,7 @@ class ZoomInfo;
 
 // A class that holds state for the duration of dragging
 // of an envelope point.
-class EnvelopeEditor
+class AUDACITY_DLL_API EnvelopeEditor
 {
 public:
    static void DrawPoints(

src/FFT.h

@@ -72,6 +72,7 @@ void PowerSpectrum(size_t NumSamples, const float *In, float *Out);
  * NumSamples must be a power of two.
  */
 
+AUDACITY_DLL_API
 void RealFFT(size_t NumSamples,
              const float *RealIn, float *RealOut, float *ImagOut);
 
@@ -80,6 +81,7 @@ void RealFFT(size_t NumSamples,
  * so the output is purely real.  NumSamples must be a power of
  * two.
  */
+AUDACITY_DLL_API
 void InverseRealFFT(size_t NumSamples,
 		    const float *RealIn, const float *ImagIn, float *RealOut);
 
@@ -89,6 +91,7 @@ void InverseRealFFT(size_t NumSamples,
  * inverse transform as well.
  */
 
+AUDACITY_DLL_API
 void FFT(size_t NumSamples,
          bool InverseTransform,
          const float *RealIn, const float *ImagIn, float *RealOut, float *ImagOut);
@@ -117,6 +120,7 @@ enum eWindowFunctions
    eWinFuncCount
 };
 
+AUDACITY_DLL_API
 void WindowFunc(int whichFunction, size_t NumSamples, float *data);
 
 /*
@@ -125,6 +129,7 @@ void WindowFunc(int whichFunction, size_t NumSamples, float *data);
  * otherwise about (NumSamples - 1) / 2
  * All functions have 0 in data[0] except Rectangular, Hamming and Gaussians
  */
+AUDACITY_DLL_API
 void NewWindowFunc(int whichFunction, size_t NumSamples, bool extraSample, float *data);
 
 /*
@@ -134,19 +139,20 @@ void NewWindowFunc(int whichFunction, size_t NumSamples, bool extraSample, float
  * otherwise about (NumSamples - 1) / 2
  * All functions have 0 in data[0] except Rectangular, Hamming and Gaussians
  */
+AUDACITY_DLL_API
 void DerivativeOfWindowFunc(int whichFunction, size_t NumSamples, bool extraSample, float *data);
 
 /*
  * Returns the name of the windowing function (for UI display)
  */
 
-const TranslatableString WindowFuncName(int whichFunction);
+AUDACITY_DLL_API const TranslatableString WindowFuncName(int whichFunction);
 
 /*
  * Returns the number of windowing functions supported
  */
 
-int NumWindowFuncs();
+AUDACITY_DLL_API int NumWindowFuncs();
 
 void DeinitFFT();
 

src/FileException.h

@@ -14,7 +14,8 @@
 #include <wx/filename.h> // wxFileName member variable
 
 //! Thrown for failure of file or database operations in deeply nested places
-class FileException /* not final */ : public MessageBoxException
+class AUDACITY_DLL_API FileException /* not final */
+   : public MessageBoxException
 {
 public:
    //! Identifies file operation that failed

src/FileFormats.h

@@ -30,6 +30,7 @@ class wxString;
 /** @brief Get the number of container formats supported by libsndfile
  *
  * Uses SFC_GET_FORMAT_MAJOR_COUNT in sf_command interface */
+AUDACITY_DLL_API
 int sf_num_headers();
 
 /** @brief Get the name of a container format from libsndfile
@@ -39,20 +40,25 @@ int sf_num_headers();
  * @param format_num The libsndfile format number for the container format
  * required
  */
+AUDACITY_DLL_API
 wxString sf_header_index_name(int format_num);
 
+AUDACITY_DLL_API
 unsigned int sf_header_index_to_type(int format_num);
 
 //
 // enumerating encodings
 //
 /** @brief Get the number of data encodings libsndfile supports (in any
  * container or none */
+AUDACITY_DLL_API
 int sf_num_encodings();
 /** @brief Get the string name of the data encoding of the requested format
  *
  * uses SFC_GET_FORMAT_SUBTYPE */
+AUDACITY_DLL_API
 wxString sf_encoding_index_name(int encoding_num);
+AUDACITY_DLL_API
 unsigned int sf_encoding_index_to_subtype(int encoding_num);
 
 //
@@ -64,20 +70,23 @@ unsigned int sf_encoding_index_to_subtype(int encoding_num);
  * then use SFC_GET_FORMAT_INFO to get the description
  * @param format the libsndfile format to get the name for (only the container
  * part is used) */
+AUDACITY_DLL_API
 wxString sf_header_name(int format);
 /** @brief Get an abbreviated form of the string name of the specified format
  *
  * Do sf_header_name() then truncate the string at the first space in the name
  * to get just the first word of the format name.
  * @param format the libsndfile format to get the name for (only the container
  * part is used) */
+AUDACITY_DLL_API
 wxString sf_header_shortname(int format);
 /** @brief Get the most common file extension for the given format
  *
  * AND the given format with SF_FORMAT_TYPEMASK to get just the container
  * format, then retrieve the most common extension using SFC_GET_FORMAT_INFO.
  * @param format the libsndfile format to get the name for (only the container
  * part is used) */
+AUDACITY_DLL_API
 wxString sf_header_extension(int format);
 /** @brief Get the string name of the specified data encoding
  *
@@ -98,13 +107,18 @@ SF_FORMAT_INFO *sf_simple_format(int i);
 // other utility functions
 //
 
+AUDACITY_DLL_API
 bool sf_subtype_more_than_16_bits(unsigned int format);
+AUDACITY_DLL_API
 bool sf_subtype_is_integer(unsigned int format);
+AUDACITY_DLL_API
 int sf_subtype_bytes_per_sample(unsigned int format);
 
+AUDACITY_DLL_API
 //! Choose the narrowest value in the sampleFormat enumeration for a given libsndfile format
 sampleFormat sf_subtype_to_effective_format(unsigned int format);
 
+AUDACITY_DLL_API
 extern FileExtensions sf_get_all_extensions();
 
 wxString sf_normalize_name(const char *name);
@@ -123,7 +137,7 @@ inline R SFCall(F fun, Args&&... args)
 }
 
 //RAII for SNDFILE*
-struct SFFileCloser { int operator () (SNDFILE*) const; };
+struct AUDACITY_DLL_API SFFileCloser { int operator () (SNDFILE*) const; };
 struct SFFile : public std::unique_ptr<SNDFILE, ::SFFileCloser>
 {
    SFFile() = default;

src/FileIO.h

@@ -18,7 +18,7 @@ class wxOutputStream;
 class wxFFileOutputStream;
 class wxFileNameWrapper;
 
-class FileIO
+class AUDACITY_DLL_API FileIO
 {
  public:
    typedef enum FileIOMode