Feature: Add support for event capturing #1214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ollieri3 First of all sorry for the long wait! Second: Thank you so much for your contribution, it's an interesting new feature. Could you add info to the documentation pages as well? And I think you need to update your branch to reflect the latest changes on the main branch, then I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change adds a new
captureoption to theuseHotkeyshook. It determines whether key events will be triggered in the capturing or bubbling phase (default) during event propogation. More info here.I've found this to be useful when setting up global hotkeys within an application where you may wish to override any child elements that
stopPropagation().I've added a test to verify this new behaviour along with documentation of the new option, please let me know If you'd like me to make any further changes.
Thanks for this awesome library.