-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build upgrade for aarch64/arm64 architecture #1399
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Code mostly look good, and you clearly understand the problem. We need a few tweaks to make it a bit cleaner and make sure we don't use the same path for different architectures.
938d921
to
49228b4
Compare
49228b4
to
67defb3
Compare
Any news about this PR mates ? |
Good question. I implemented everything that was needed for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. This looks great!
Please, approve changes again. I fixed the crashed build |
79a9fd2
to
22fe532
Compare
@cleardevice any idea why the Shadowbox test is failing? Does it fail in your machine as well? |
It was a DockerHub problem. Everything should be fine now |
So since all the checks have passed, should we expect soon a new release that supports ARM machines? TBH, I really don't like that we rely on 3rd party images in order to get Outline working. thanks for your hard work mate 🙏🏼 |
Thanks for the contribution. It's now merged. I'll try to release in the next few weeks. I don't really know how to release multi-arch docker images, so I'll need to figure that out. |
This is the main reason for this changes. Using Outline for security, we shouldn't trust 3rd party images. Otherwise, what kind of zero trust can we talk about?
or build personal one and use it from own DockerHub:
Feel free to contact me if you have any problems with build or launch. |
I'm glad that my contribution is useful to the community. Now we can build 4 images: Linux (x86_64, Arm64) and macOS-Darwin (x86_64, Arm64). Feel free to contact me if you need help with building an image or CI customization. |
Hello Mates, Thanks for your hard work 🙏🏼 |
Hey - it should be released in the new version, when that happens! |
No description provided.