Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add server manager install script to support rootless docker #1293

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Friend-LGA
Copy link

@Friend-LGA Friend-LGA commented Feb 18, 2023

Right now default install flow is using this script

sudo bash -c "$(wget -qO- https://raw.githubusercontent.com/Jigsaw-Code/outline-server/master/src/server_manager/install_scripts/install_server.sh)"

This one doesn't work with Rootless Docker because of 2 reasons:

  • --net host flag
  • usage of watchtower

This PR adds new script install_server_rootless.sh which maps docker ports directly using -p flag and removes usage of watchtower.

Works with Rootless Docker (tested).

Example usage

bash -c "SHADOWBOX_DIR=$HOME/outline-data $(wget -qO- https://raw.githubusercontent.com/Jigsaw-Code/outline-server/master/src/server_manager/install_scripts/install_server_rootless.sh)"

Notice no sudo is here and custom shadowbox dir.

@Friend-LGA Friend-LGA requested a review from a team as a code owner February 18, 2023 09:06
@google-cla
Copy link

google-cla bot commented Feb 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Friend-LGA Friend-LGA changed the title Add server manager install script to support rootless docker feat(scripts): add server manager install script to support rootless docker Feb 18, 2023
@Friend-LGA Friend-LGA changed the title feat(scripts): add server manager install script to support rootless docker feat(server): add server manager install script to support rootless docker Feb 18, 2023
@Friend-LGA Friend-LGA marked this pull request as draft February 19, 2023 09:38
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. However, there are a few issues:

  • It doesn't fully work. If one changes the port for access keys, Docker won't be mapping those new ports, so it won't work. That's why we use --net host. We also need that to determine what ports are in use.
  • It loses the history, so I can't tell what the differences are from the original script
  • It introduces a lot of duplicate code to maintain

You need to address those issues in order for us to consider merging the contributions.
Why do you need Rootless mode in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants