Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make middle strip in geomCrossbar() optional #233

Closed
AndreiKingsley opened this issue Jan 29, 2024 · 6 comments
Closed

Make middle strip in geomCrossbar() optional #233

AndreiKingsley opened this issue Jan 29, 2024 · 6 comments

Comments

@AndreiKingsley
Copy link
Contributor

This is a fairly common usecase , i.e. the user needs the bars themselves, without the middle bar. That is, I'd like to propose the following behavior: if y is not assigned, the bar is not drawn (as it is currently when passing a list of nulls).
Actual:
image
Expected:
image

We did already the same for boxplot: #143

@alshan
Copy link
Collaborator

alshan commented Jan 29, 2024

Hi, try using fatten = 0

@AndreiKingsley
Copy link
Contributor Author

Ok, but let's get rid of middle bars on 0, why not?

@alshan
Copy link
Collaborator

alshan commented Jan 29, 2024

0 is a legit value.

@AndreiKingsley
Copy link
Contributor Author

I mean if y is not assigned, don't draw a middle bar at all instead od drawn it at 0

@alshan
Copy link
Collaborator

alshan commented Jan 29, 2024

Got it.

@alshan alshan added this to the 2024Q1 milestone Jan 29, 2024
@alshan alshan added bug Something isn't working and removed bug Something isn't working labels Jan 29, 2024
@alshan
Copy link
Collaborator

alshan commented Feb 15, 2024

Fixed by commit: JetBrains/lets-plot@8a554dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants