Expect androidx.compose.material.AlertDialog in common#708
Merged
MatkovIvan merged 9 commits intojb-mainfrom Aug 10, 2023
Merged
Expect androidx.compose.material.AlertDialog in common#708MatkovIvan merged 9 commits intojb-mainfrom
androidx.compose.material.AlertDialog in common#708MatkovIvan merged 9 commits intojb-mainfrom
Conversation
igordmn
reviewed
Jul 28, 2023
ebda8b2 to
3020ef1
Compare
c3a1276 to
fec2221
Compare
3b1e95e to
87da601
Compare
igordmn
approved these changes
Aug 9, 2023
# Conflicts: # compose/material/material/src/desktopTest/kotlin/androidx/compose/material/DesktopAlertDialogTest.kt
igordmn
pushed a commit
that referenced
this pull request
Nov 15, 2023
…log` in common (#708) * Expect AlertDialog in common * Remove experimental desktop-only AlertDialog * Update DesktopAlertDialogTest * Configure skikoMain * Add AlertDialogWindow instead of UndecoratedWindowAlertDialogProvider * Update comment * Update button size in run3 app * Revert AlertDialogWindow
copybara-service Bot
pushed a commit
to androidx/androidx
that referenced
this pull request
May 23, 2024
It's upstreaming of JetBrains#708. This API is already available from common since Compose Multiplatform 1.5.0 Test: N/A Relnote: Make `androidx.compose.material.AlertDialog` available from common source set Change-Id: If9fd3fe4a9d232e289df22cb9aee9e6430fc51af
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
AlertDialogin commonDialogfrom Expect Dialog in common #632AlertDialogandAlertDialogProviderAPI Change
Added
AlertDialogAPI to common source set:Please note that new overload might behave differently than previous desktop-only experimental API
Testing
Test: run test apps or try to use
AlertDialogin commonIssues Fixed
DropDownMenuorAlertDialogin common source set compose-multiplatform#762