Expect Dialog in common #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
changed the base branch from
jb-main
to
ivan.matkov/fix-multi-owner-input
MatkovIvan
force-pushed
the
ivan.matkov/common-dialog
branch
from
b4bdf41
to
0b7707c
Compare
igordmn
reviewed
Jul 11, 2023
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt
Show resolved
Hide resolved
MatkovIvan
force-pushed
the
ivan.matkov/common-dialog
branch
from
0b7707c
to
f486088
Compare
igordmn
approved these changes
Jul 18, 2023
This was referenced Jul 26, 2023
copybara-service bot
pushed a commit
to androidx/androidx
that referenced
this pull request
Jan 19, 2024
Dialog available on all platforms but currently has no shared API in common. Exposing android overloads with DialogProperties allow use it from the common source set and unblocks commonization of many material components. Proposed changes: - Move 'Dialog' and part of `DialogProperties` to common - Add implementation for desktop. Escape is used for handling `dismissOnBackPress` flag Upstreaming changes from JetBrains#632 Relnote: Added a new `DialogProperties` constructor without platform-specific parameters Test: N/A Change-Id: I45829f07645b4457e3f6cbdfe98b1a0d59bafdff
igordmn
pushed a commit
that referenced
this pull request
Jan 30, 2024
I think this line (1093) `.setContentIntent(notification.contentIntent)` is duplicated of line (1110). ## Proposed Changes - Remove duplicate "setContentIntent" ## Testing Test: None This is an imported pull request from androidx#632. Resolves #632 Github-Pr-Head-Sha: e6e09c7 GitOrigin-RevId: 7bb049d Change-Id: If3db1141126dd700f5ecb60ce8e7344a888bfd84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
DialogPropertiesto common, it's not binary compatible, but it's source code compatible. It works because the code from common compiles as code substitution on each platformDialogProperties.dismissOnBackPressflag in skiko implementationDialogProperties.dismissOnClickOutsideflag in skiko implementationTesting
Test: try to use
Dialogfrom common sourcesetRelated PRs