Fix perspective transform usage #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just some thoughts about a test: PointerIconTest - is an example with pointer input in tests. |
eymar
approved these changes
Jun 6, 2023
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaLayer.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaLayer.skiko.kt
Show resolved
Hide resolved
MatkovIvan
force-pushed
the
ivan.matkov/fix-input-transform
branch
from
ea76bb6
to
1f63516
Compare
MatkovIvan
force-pushed
the
ivan.matkov/fix-input-transform
branch
from
1f63516
to
5586d14
Compare
eymar
reviewed
Jun 7, 2023
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaLayer.skiko.kt
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
eymar
approved these changes
Jun 7, 2023
I already added tests that fails on main branch, but let's add extra one, sure |
|
BTW I guess it fixes JetBrains/compose-multiplatform#1718 too |
MatkovIvan
added a commit
that referenced
this pull request
Jun 8, 2023
* Fix perspective transform usage * Add graphicsLayer settings page to mpp * Add inverseMatrix.map tests * Fix inverseMatrix for rotated layer # Conflicts: # compose/mpp/demo/src/commonMain/kotlin/androidx/compose/mpp/demo/App.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
matrix[2, 2]should not be zeroed, and perspective transform should be applied only in case of rotation.inverseMatrixdo opposite than applyingmatrixTesting
Test: run code from JetBrains/compose-multiplatform#3230 (comment)
Unit tests: run tests from
SkiaLayerTestIssues Fixed
Fixes JetBrains/compose-multiplatform#3230