Skip to content

Small optimalisations on the mounted devices to make the experience more seamless #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: development-docker-compose-2
Choose a base branch
from

Conversation

JCombee
Copy link
Contributor

@JCombee JCombee commented Mar 7, 2025

No description provided.

@JeroenBoersma
Copy link
Owner

Hi @JCombee, thanks for your submission. Adding the external: true flag for the volumes is backwards incompatible and would mean that every environment someone uses will break when pulling this change in.

Let's see if we can make it work both ways! Maybe we can have a flag to identify that it is set as an external volume.
This could work for everything and making it more generic, which then can also be applied to mysql

Is this something you want to look at or do you want me to test this out for you?

@JeroenBoersma
Copy link
Owner

What is search.php? That's not Magento default I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants