Skip to content

Add submissionCalendar field #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

volyx
Copy link
Contributor

@volyx volyx commented Feb 3, 2021

Field subissionCalendar is necessary for building Leetcode activity chart like this

image

@JeremyTsaii JeremyTsaii merged commit 5287805 into JeremyTsaii:main Feb 3, 2021
@JeremyTsaii
Copy link
Owner

Really appreciate the PR! The error handling (to reduce the arguments passed in StatsResponse) is particularly nice. Thanks for also adding tests for the Submission Calendar.

@JeremyTsaii
Copy link
Owner

Just wondering, are you currently planning to build a Leetcode activity chart in a project?

@volyx
Copy link
Contributor Author

volyx commented Feb 4, 2021

@JeremyTsaii Thx! Yes, I was thinking about building an activity chart - JeremyTsaii/leetcode-stats#1

But It may take time because I'm not really good at writing svg and js.

@JeremyTsaii
Copy link
Owner

That's a great idea. That's okay, I look forward to it :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants