Issue: Out of memory error and High CPU usage#2
Merged
JensBorrisholt merged 1 commit intoDevelopmentfrom Mar 28, 2021
Merged
Conversation
…U usage and when JSON is valid, the parsed JSON response is leaked leading to Out of Memory error. Suggested change to only validate JSON on MemoJSON changed and free the leaked TJSONObject in TPkgJsonMapper.IsValid. ARC has been deprecated, so instances need to be managed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that once a JSON document was loaded into MemoJSON than the Action List Update calls were checking JSON IsValid continuously causing high CPU usage and when the JSON is valid, the parsed JSON object in IsValid was leaked which quickly leads to an Out of Memory error. The suggested change is to only validate the JSON when MemoJSON has been changed as well as free the leaked TJSONObject in TPkgJsonMapper.IsValid. To test, paste a sizable valid JSON doc in the memo and watch CPU and memory. Out of Memory errors occurred pretty quickly in my testing of sizeable JSON content.
SampleJSON.zip