Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate State vs Overrides #49

Open
slominskir opened this issue May 29, 2024 · 0 comments
Open

Separate State vs Overrides #49

slominskir opened this issue May 29, 2024 · 0 comments

Comments

@slominskir
Copy link
Member

Consider having separate state of Active vs Normal as that's usually the most important thing. Whether an Override is being used is a separate secondary concern. Currently there is a single enum that does both simultaneously, requiring clients to parse to figure out Active vs Normal:

https://github.com/JeffersonLab/jaws-libp/blob/22fe5ed50483df574be2447bab418e8e450c475e/src/jaws_libp/avro/schemas/EffectiveNotification.avsc#L22-L24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant