Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Simultaneous Incite + Suppress Overrides #24

Open
slominskir opened this issue Jul 13, 2021 · 1 comment
Open

Improve Simultaneous Incite + Suppress Overrides #24

slominskir opened this issue Jul 13, 2021 · 1 comment

Comments

@slominskir
Copy link
Member

slominskir commented Jul 13, 2021

When both an incite and suppress override are set simultaneously we may want to automatically cancel the incite override. The latched and one-shot overrides are particularly clumsy to combine. When ops requests one-shot shelved they are effectively asking to ignore the current annunciation (or next if currently Normal) of an alarm, but when combined with latching the result is that ops still must ack. One work-around is client software can simply always send an ack with a one-shot shelve request (though this only works if alarm in question is currently Active). We may need to consider other combinations of overrides as well, like off-delayed and on-delayed, which may make a confusing experience.

@slominskir
Copy link
Member Author

There are also implications for caching as it turns out JLab alarms in practice are often actively alarming when they really are "not in use". This means caches of overrides often contain useless Latched overrides for alarms that are supposed to be filtered out anyways. So if filtered out, Latches should probably be dropped to keep caches clear of useless info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant