dsts assume symmetric covariance matrix

baltzell · baltzell · commit 0897844bbd62 · 2026-02-03T18:13:23.000-05:00
diff --git a/common-tools/clas-reco/src/main/java/org/jlab/clas/detector/DetectorData.java b/common-tools/clas-reco/src/main/java/org/jlab/clas/detector/DetectorData.java
@@ -522,7 +522,7 @@ public static DataBank getCovMatrixBank(List<DetectorParticle> particles, DataEv
                 bank.setShort("index", row, (short) p.getTrackIndex());
                 bank.setShort("pindex", row, (short) i);
                 for (int ii = 0; ii < 6; ii++) {
-                    for (int jj = 0; jj < 6; jj++) {
+                    for (int jj = ii; jj < 6; jj++) {
                         String varName = String.format("C%d%d", ii + 1, jj + 1);
                         bank.setFloat(varName, row, p.getCovMatrix(ii, jj));
                     }
@@ -598,7 +598,7 @@ public static List<DetectorTrack> readDetectorTracks(DataEvent event, String ban
                             continue;
                         }
                         for (int jj = 1; jj <= dimCovMat; jj++) {
-                            for (int kk = 1; kk <= dimCovMat; kk++) {
+                            for (int kk = jj; kk <= dimCovMat; kk++) {
                                 float ele = covBank.getFloat(String.format("C%d%d", jj, kk), ii);
                                 track.setCovMatrix(jj - 1, kk - 1, ele);
                             }

Original file line number	Diff line number	Diff line change
`@@ -522,7 +522,7 @@ public static DataBank getCovMatrixBank(List<DetectorParticle> particles, DataEv`
`522`	`522`	`bank.setShort("index", row, (short) p.getTrackIndex());`
`523`	`523`	`bank.setShort("pindex", row, (short) i);`
`524`	`524`	`for (int ii = 0; ii < 6; ii++) {`
`525`		`- for (int jj = 0; jj < 6; jj++) {`
	`525`	`+ for (int jj = ii; jj < 6; jj++) {`
`526`	`526`	`String varName = String.format("C%d%d", ii + 1, jj + 1);`
`527`	`527`	`bank.setFloat(varName, row, p.getCovMatrix(ii, jj));`
`528`	`528`	`}`
`@@ -598,7 +598,7 @@ public static List<DetectorTrack> readDetectorTracks(DataEvent event, String ban`
`598`	`598`	`continue;`
`599`	`599`	`}`
`600`	`600`	`for (int jj = 1; jj <= dimCovMat; jj++) {`
`601`		`- for (int kk = 1; kk <= dimCovMat; kk++) {`
	`601`	`+ for (int kk = jj; kk <= dimCovMat; kk++) {`
`602`	`602`	`float ele = covBank.getFloat(String.format("C%d%d", jj, kk), ii);`
`603`	`603`	`track.setCovMatrix(jj - 1, kk - 1, ele);`
`604`	`604`	`}`