Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attenuation factor for 5249-5340 is incorrect #12

Closed
2 tasks
c-dilks opened this issue May 12, 2022 · 1 comment
Closed
2 tasks

Attenuation factor for 5249-5340 is incorrect #12

c-dilks opened this issue May 12, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@c-dilks
Copy link
Member

c-dilks commented May 12, 2022

For runs in the range 5249-5340, the beam blocker attenuation was incorrect: 10.61360 instead of 9.8088. Beam charge overestimated by about 8%.

  • update QADB charge
  • update monitorRead.groovy

CAUTION:

  • if this is fixed for Pass1, it runs the risk of messing up analyzers who fix this downstream of QA code
  • if this is not fixed for Pass1, it runs the risk of messing up new analyzers who are not aware this needs to be done
  • in any case, this fix should not be needed for Pass 2
@c-dilks c-dilks self-assigned this May 12, 2022
@c-dilks c-dilks added this to the Pass 1 Backports milestone Sep 11, 2023
@c-dilks c-dilks added the bug Something isn't working label Sep 11, 2023
@c-dilks c-dilks pinned this issue Mar 29, 2024
@c-dilks
Copy link
Member Author

c-dilks commented Oct 22, 2024

  • Pass 1 analyzers are aware of this issue; we could assign Misc for these runs, but since those analyses are in rather advanced states, let's not "fix" this issue like this
  • Pass 2 should not have this issue any more
  • It's not the QA's job to fix problems in the data, rather it reports the data quality (and the charge) as is

@c-dilks c-dilks closed this as not planned Won't fix, can't repro, duplicate, stale Oct 22, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in CLAS12 Timelines Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant