-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option selection on mouse down not mouse up #432
Comments
I have the same problem. I'm using onChange callback to trigger change page on react-router. With MouseDown the elements on new page receive a click event. It happen because the new page appear before MouseUp. The react-select handle MouseDown and TouchEnd but for my opinion is better to use combination of MouseDown/TouchStart or MouseUp/TouchEnd. |
I am going in the same issue any update ? |
got same issue, any solution? |
We can pass an |
@dalizwei thank you very much, very good solution. |
+1 Still seeing this problem on mobile (ipad). unfortunately @dalizwei 's solution does not work so well for mobile devices with touch events |
@camlough i think it's the same thing, on mobile devise, you should check tap event rather than click event. |
@Sen yeah i tried the same implementation but using So i tried this:
And that partially fixed the scrolling problem, but it was still very choppy, so not a viable solution |
Version 1 of react-select is no longer supported. In the best interest of the community we've decided to spend the time we have available on the latest version. We apologise for any inconvenience. Please see: |
In my UI, when a user wants to create a new option in the list, I want to provide a modal dialog to the user so that can set additional data about the the new option they are creating.
My problem is that the onChange event is triggered on the MouseDown event. At this point I create the dialog, however when the MouseUp event happens afterwards, because the user's mouse is not inside the dialog, the dialog gets dismissed.
I think the best solution would be to make selection on mouse up (or allow the programmer to decide on which event it should occur on instead of hard coding it)
The text was updated successfully, but these errors were encountered: