Skip to content

Conversation

@JasonXuDeveloper
Copy link
Owner

Summary

Fixes two issues with the release workflow:

1. Release created by wrong bot

Before: Releases were created by github-actions[bot] because GITHUB_TOKEN was used

After: Releases will be created by jengine-release-bot[bot] using the app token

+ - name: Generate GitHub App Token
+   uses: actions/create-github-app-token@v1
+   with:
+     app-id: ${{ secrets.RELEASE_APP_ID }}
+     private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}

- GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ GH_TOKEN: ${{ steps.generate-token.outputs.token }}

2. Inconsistent CHANGE.md formatting

Before: Conventional commits were bolded, others were not

- **Add feature X** (ci)      <- bold
- Fix something Y             <- not bold

After: All entries use consistent formatting (no bold)

- Add feature X (ci)
- Fix something Y

Test plan

  • Merge this PR
  • Delete 1.0.8 tag and release
  • Run release workflow with core_version=1.0.9 and util_version=1.0.3
  • Verify release is created by jengine-release-bot[bot]
  • Verify CHANGE.md entries have consistent formatting

🤖 Generated with Claude Code

- Use GitHub App token for creating releases so JEngine Release Bot
  is shown as the author instead of github-actions
- Remove bold formatting from CHANGE.md entries for consistency
  (all entries now use same format regardless of commit type)

Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
@JasonXuDeveloper JasonXuDeveloper enabled auto-merge (squash) January 25, 2026 10:09
@claude
Copy link

claude bot commented Jan 25, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@github-actions
Copy link

Unity Test Results

EditMode: All tests passed
PlayMode: All tests passed

Unity Version: 2022.3.55f1
Project Path: UnityProject

✅ All tests passed! The PR is ready for review.

View workflow run

Click here to view the full workflow run

@JasonXuDeveloper JasonXuDeveloper merged commit 4d4adb4 into master Jan 25, 2026
11 checks passed
@JasonXuDeveloper JasonXuDeveloper deleted the fix/release-bot-and-formatting branch January 25, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant