Skip to content

Conversation

@JasonXuDeveloper
Copy link
Owner

Summary

Fixes issues from release 1.0.6 that were identified:

1. PR hyperlinks now added everywhere

  • Entries like (#567) are now converted to ([#567](https://github.com/.../pull/567))
  • This applies to CHANGE.md, README files, and GitHub release notes

2. Proper contributor usernames

Before: Used git author names like "JasonXuDeveloper - 傑" or "Rock" which don't match GitHub usernames

After: Uses GitHub API to get actual PR authors, with proper links:

  • [@JasonXuDeveloper](https://github.com/JasonXuDeveloper)
  • Bot accounts are automatically filtered out

3. Bot avatar issue

The bot email format {APP_ID}+jengine-release-bot[bot]@users.noreply.github.com is correct. If the avatar still doesn't show, you may need to:

  1. Go to GitHub App settings
  2. Ensure the app has an avatar/logo set
  3. Verify the app slug matches "jengine-release-bot"

Changes

- COMMITS=$(git log ... --pretty=format:"%H|%s|%an" ...)
+ COMMITS=$(git log ... --pretty=format:"%H|%s" ...)

+ # Extract PR number and convert to hyperlink
+ if [[ $subject =~ \(#([0-9]+)\)$ ]]; then
+   pr_link="[#${pr_num}](https://github.com/${REPO}/pull/${pr_num})"
+   # Get contributor from PR using GitHub API
+   pr_author=$(gh api "repos/${REPO}/pulls/${pr_num}" --jq '.user.login')
+ fi

- CONTRIBUTORS="${CONTRIBUTORS}@$author, "
+ CONTRIBUTORS="${CONTRIBUTORS}[@${contributor}](https://github.com/${contributor}), "

Test plan

  • Merge this PR
  • Run release workflow with core_version=1.0.7 and util_version=1.0.1
  • Verify PR hyperlinks appear in CHANGE.md
  • Verify PR hyperlinks appear in README.md and README_zh_cn.md
  • Verify contributors list shows proper GitHub usernames with links
  • Verify no bot accounts in contributors

🤖 Generated with Claude Code

- Add PR hyperlinks to all changelog entries (CHANGE.md, README, release)
- Use GitHub API to get actual PR authors instead of git author names
- Filter out bot accounts from contributors list
- Fix bot email to use user ID (257041894) instead of App ID for proper avatar

Signed-off-by: JasonXuDeveloper - 傑 <jason@xgamedev.net>
@JasonXuDeveloper JasonXuDeveloper force-pushed the fix/release-workflow-improvements branch from 6327721 to a7eaa09 Compare January 25, 2026 09:31
@github-actions
Copy link

github-actions bot commented Jan 25, 2026

Unity Test Results

EditMode: All tests passed
PlayMode: All tests passed

Unity Version: 2022.3.55f1
Project Path: UnityProject

✅ All tests passed! The PR is ready for review.

View workflow run

Click here to view the full workflow run

@claude
Copy link

claude bot commented Jan 25, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@JasonXuDeveloper JasonXuDeveloper enabled auto-merge (squash) January 25, 2026 09:33
@claude
Copy link

claude bot commented Jan 25, 2026

Code Review

Issue Found

File: .github/workflows/release.yml (Line 200)

Problem: The sed command will fail because the replacement string contains forward slashes (/) that conflict with sed's / delimiter.

When the code executes:

subject=$(echo "$subject" | sed "s/(#${pr_num})/(${pr_link})/")

With pr_link="[#567](https://github.com/JasonXuDeveloper/JEngine/pull/567)", sed will see:

sed "s/(#567)/([#567](https://github.com/JasonXuDeveloper/JEngine/pull/567))/"

Sed interprets the first / in https:// as the end-of-replacement delimiter, causing a parsing error.

Fix: Use a different sed delimiter that doesn't appear in URLs, such as |:

subject=$(echo "$subject" | sed "s|(#${pr_num})|(${pr_link})|")

Reference:

pr_num="${BASH_REMATCH[1]}"
pr_link="[#${pr_num}](https://github.com/${REPO}/pull/${pr_num})"
# Replace (#123) with the hyperlink
subject=$(echo "$subject" | sed "s/(#${pr_num})/(${pr_link})/")


Summary: Checked for bugs and CLAUDE.md compliance. Found 1 issue.

@JasonXuDeveloper JasonXuDeveloper merged commit 26ae381 into master Jan 25, 2026
11 checks passed
@JasonXuDeveloper JasonXuDeveloper deleted the fix/release-workflow-improvements branch January 25, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant