Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action claims that the dist/index.js file doesn't exist? #4

Closed
lee-dohm opened this issue May 16, 2020 · 6 comments · Fixed by #5
Closed

Action claims that the dist/index.js file doesn't exist? #4

lee-dohm opened this issue May 16, 2020 · 6 comments · Fixed by #5

Comments

@lee-dohm
Copy link

When I run npm ci && npm run build locally on the latest code in my repo, the dist/index.js file is created. So I'm not sure why I'm getting this error?

Thoughts?

@JasonEtco
Copy link
Owner

Hm, thanks for opening, and for trying it out @lee-dohm. Everything looks correct to me 🤔 I'm guessing that the setup script wasn't run, otherwise we'd see the log output. It should have run though; I added some more logs in cba5909 so we should at least see what it's doing with the setup script. Are you able to try again?

@JasonEtco
Copy link
Owner

JasonEtco commented May 16, 2020

Saw that you re-ran it @lee-dohm, thanks 🙏 So:

image

It looks like @actions/exec doesn't map super well for commands with &&. I didn't catch it in this repo, because I have to build it in the workflow instead of in the action itself (so I set setup: '', can't use it if it ain't built yet). I'm not sure how to solve this 😞 Might be worth removing the setup script entirely, rather than have something that only works sometimes.

@lee-dohm
Copy link
Author

Hmmm ... let me try changing to using run steps instead of relying on the setup script and see if that works 🤔

@lee-dohm
Copy link
Author

Yep, that worked 👍 Want me to leave this open for you to track the problem?

@JasonEtco
Copy link
Owner

Yes please, thanks @lee-dohm!! I'm going to first see if there's a "right way" to do multiple commands, might need a change to @actions/exec. If that doesn't pan out, I'll remove the setup script entirely.

@lee-dohm
Copy link
Author

Thank you for building this so I don't have to 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants