style: improve style of code

Author: alexander-akait

bin/webpack.js

@@ -113,8 +113,7 @@ if (!cli.installed) {
 	const fs = require("graceful-fs");
 	const readLine = require("readline");
 
-	const notify =
-		"CLI for webpack must be installed.\n" + `  ${cli.name} (${cli.url})\n`;
+	const notify = `CLI for webpack must be installed.\n  ${cli.name} (${cli.url})\n`;
 
 	console.error(notify);
 

eslint.config.js

@@ -6,6 +6,7 @@ const jsdoc = require("eslint-plugin-jsdoc");
 const prettierConfig = require("eslint-config-prettier");
 const globals = require("globals");
 
+const nodeConfig = n.configs["flat/recommended"];
 const jsdocConfig = jsdoc.configs["flat/recommended-typescript-flavor-error"];
 
 module.exports = [
@@ -36,16 +37,60 @@ module.exports = [
 			// Ignore precompiled schemas
 			"schemas/**/*.check.js",
 
+			// Auto generation
+			"lib/util/semver.js",
+
 			// Ignore some examples files
 			"examples/**/*.js",
 			"examples/**/*.mjs",
 			"!examples/*/webpack.config.js"
 		]
 	},
 	js.configs.recommended,
-	n.configs["flat/recommended"],
+	{
+		...nodeConfig,
+		rules: {
+			...nodeConfig.rules,
+			"n/no-missing-require": ["error", { allowModules: ["webpack"] }],
+			"n/no-unsupported-features/node-builtins": [
+				"error",
+				{
+					ignores: ["zlib.createBrotliCompress", "zlib.createBrotliDecompress"]
+				}
+			],
+			"n/exports-style": "error"
+		}
+	},
 	{
 		...jsdocConfig,
+		settings: {
+			jsdoc: {
+				mode: "typescript",
+				// supported tags https://github.com/microsoft/TypeScript-wiki/blob/master/JSDoc-support-in-JavaScript.md
+				tagNamePreference: {
+					...["implements", "const", "memberof", "yields"].reduce(
+						(acc, tag) => {
+							acc[tag] = {
+								message: `@${tag} currently not supported in TypeScript`
+							};
+							return acc;
+						},
+						{}
+					),
+					extends: "extends",
+					return: "returns",
+					constructor: "constructor",
+					prop: "property",
+					arg: "param",
+					augments: "extends",
+					description: false,
+					desc: false,
+					inheritdoc: false,
+					class: "constructor"
+				},
+				overrideReplacesDocs: false
+			}
+		},
 		rules: {
 			...jsdocConfig.rules,
 			// Override recommended
@@ -98,10 +143,17 @@ module.exports = [
 			"no-use-before-define": "off",
 			"no-unused-vars": [
 				"error",
-				{ caughtErrors: "none", args: "none", ignoreRestSiblings: true }
+				{
+					vars: "all",
+					varsIgnorePattern: "^_",
+					args: "none",
+					argsIgnorePattern: "^_",
+					caughtErrors: "none",
+					caughtErrorsIgnorePattern: "^_",
+					ignoreRestSiblings: true
+				}
 			],
 			"no-inner-declarations": "error",
-			"no-loop-func": "off",
 			"prefer-const": [
 				"error",
 				{
@@ -113,47 +165,110 @@ module.exports = [
 			"no-else-return": "error",
 			"no-lonely-if": "error",
 			"no-undef-init": "error",
-			"n/no-missing-require": ["error", { allowModules: ["webpack"] }],
-			"n/no-unsupported-features/node-builtins": [
+			// Disallow @ts-ignore directive. Use @ts-expect-error instead
+			"no-warning-comments": [
+				"error",
+				{ terms: ["@ts-ignore"], location: "start" }
+			],
+			"no-constructor-return": "error",
+			"symbol-description": "error",
+			"array-callback-return": [
 				"error",
 				{
-					ignores: ["zlib.createBrotliCompress", "zlib.createBrotliDecompress"]
+					allowImplicit: true
 				}
 			],
-			"n/exports-style": "error",
-			// Disallow @ts-ignore directive. Use @ts-expect-error instead
-			"no-warning-comments": [
+			"no-promise-executor-return": "error",
+			"no-undef": "error",
+			"guard-for-in": "error",
+			"no-constant-condition": "error",
+			camelcase: [
 				"error",
-				{ terms: ["@ts-ignore"], location: "start" }
-			]
-		},
-		settings: {
-			jsdoc: {
-				mode: "typescript",
-				// supported tags https://github.com/microsoft/TypeScript-wiki/blob/master/JSDoc-support-in-JavaScript.md
-				tagNamePreference: {
-					...["implements", "const", "memberof", "yields"].reduce(
-						(acc, tag) => {
-							acc[tag] = {
-								message: `@${tag} currently not supported in TypeScript`
-							};
-							return acc;
-						},
-						{}
-					),
-					extends: "extends",
-					return: "returns",
-					constructor: "constructor",
-					prop: "property",
-					arg: "param",
-					augments: "extends",
-					description: false,
-					desc: false,
-					inheritdoc: false,
-					class: "constructor"
-				},
-				overrideReplacesDocs: false
-			}
+				{
+					allow: [
+						"__webpack_require__",
+						"__webpack_public_path__",
+						"__webpack_base_uri__",
+						"__webpack_modules__",
+						"__webpack_chunk_load__",
+						"__non_webpack_require__",
+						"__webpack_nonce__",
+						"__webpack_hash__",
+						"__webpack_chunkname__",
+						"__webpack_get_script_filename__",
+						"__webpack_runtime_id__",
+						"__system_context__",
+						"__webpack_share_scopes__",
+						"__webpack_init_sharing__",
+						"__webpack_require_module__",
+						"_stream_duplex",
+						"_stream_passthrough",
+						"_stream_readable",
+						"_stream_transform",
+						"_stream_writable",
+						"string_decoder"
+					]
+				}
+			],
+			"prefer-exponentiation-operator": "error",
+			"no-useless-return": "error",
+			"no-return-assign": "error",
+			"default-case-last": "error",
+			"default-param-last": "error",
+			"dot-notation": "error",
+			"grouped-accessor-pairs": "error",
+			"id-match": [
+				"error",
+				"^[$a-zA-Z_][$a-zA-Z0-9_]*$",
+				{
+					properties: true
+				}
+			],
+			"no-extra-label": "error",
+			"no-label-var": "error",
+			"no-lone-blocks": "error",
+			"no-multi-str": "error",
+			"no-new-func": "error",
+			"no-unneeded-ternary": ["error", { defaultAssignment: false }],
+			"no-useless-call": "error",
+			"no-useless-concat": "error",
+			"prefer-object-spread": "error",
+			"prefer-regex-literals": "error",
+			"prefer-rest-params": "error",
+
+			// TODO Enable
+			"no-sequences": "off",
+			"prefer-spread": "off",
+			"default-case": "off",
+			"new-cap": [
+				"off",
+				{
+					newIsCap: true,
+					newIsCapExceptions: [],
+					capIsNew: true,
+					capIsNewExceptions: [],
+					properties: true
+				}
+			],
+			"no-loop-func": "off",
+			"no-implicit-coercion": "off",
+			"arrow-body-style": "off",
+			"no-shadow": "off",
+			"prefer-template": "off",
+			"prefer-destructuring": "off",
+			"func-style": "off",
+			"no-plusplus": "off",
+			"no-param-reassign": "off",
+			"no-var": "off",
+			"one-var": "off",
+			"vars-on-top": "off",
+			"no-unreachable-loop": "off",
+			"no-unmodified-loop-condition": "off",
+			"@stylistic/lines-between-class-members": "off",
+			"@stylistic/quotes": "off",
+			"@stylistic/spaced-comment": "off",
+			// TODO Disable everywhere?
+			"no-useless-constructor": "off"
 		}
 	},
 	{
@@ -225,19 +340,14 @@ module.exports = [
 					allowExperimental: true
 				}
 			],
-			"object-shorthand": "off"
+			"object-shorthand": "off",
+			camelcase: "off"
 		}
 	},
 	{
 		files: ["examples/**/*.js"],
 		rules: {
 			"n/no-missing-require": "off"
 		}
-	},
-	{
-		files: ["lib/util/semver.js"],
-		rules: {
-			"n/exports-style": "off"
-		}
 	}
 ];

lib/CacheFacade.js

@@ -38,6 +38,7 @@ class MultiItemCache {
 	 */
 	constructor(items) {
 		this._items = items;
+		// eslint-disable-next-line no-constructor-return
 		if (items.length === 1) return /** @type {any} */ (items[0]);
 	}
 

lib/Compilation.js

@@ -1125,6 +1125,7 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
 			// properties in the prototype chain
 			/** @type {Partial<NormalizedStatsOptions>} */
 			const options = {};
+			// eslint-disable-next-line guard-for-in
 			for (const key in optionsOrPreset) {
 				options[key] = optionsOrPreset[key];
 			}
@@ -2056,11 +2057,9 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
 					...contextInfo
 				},
 				resolveOptions: originModule ? originModule.resolveOptions : undefined,
-				context: context
-					? context
-					: originModule
-						? originModule.context
-						: this.compiler.context,
+				context:
+					context ||
+					(originModule ? originModule.context : this.compiler.context),
 				dependencies
 			},
 			(err, result) => {
@@ -4411,7 +4410,7 @@ This prevents using hashes of each other and should be avoided.`);
 				return;
 			}
 			const oldInfo = this.assetsInfo.get(file);
-			const newInfo = Object.assign({}, oldInfo, assetInfo);
+			const newInfo = { ...oldInfo, ...assetInfo };
 			this._setAssetInfo(file, newInfo, oldInfo);
 			return;
 		}

lib/ConditionalInitFragment.js

@@ -53,7 +53,7 @@ class ConditionalInitFragment extends InitFragment {
 		position,
 		key,
 		runtimeCondition = true,
-		endContent
+		endContent = undefined
 	) {
 		super(content, stage, position, key, endContent);
 		this.runtimeCondition = runtimeCondition;

lib/ContextModule.js

@@ -565,7 +565,7 @@ class ContextModule extends Module {
 		} else if (typeof this.options.resource === "string") {
 			contextDependencies.add(this.options.resource);
 		} else if (this.options.resource === false) {
-			return;
+			// Do nothing
 		} else {
 			for (const res of this.options.resource) contextDependencies.add(res);
 		}

lib/ExportsInfo.js

@@ -877,21 +877,21 @@ class ExportInfo {
 	}
 
 	// TODO webpack 5 remove
-	/** @private */
-	get used() {
-		throw new Error("REMOVED");
-	}
-	/** @private */
-	get usedName() {
-		throw new Error("REMOVED");
-	}
 	/**
 	 * @private
 	 * @param {*} v v
 	 */
 	set used(v) {
 		throw new Error("REMOVED");
 	}
+
+	// TODO webpack 5 remove
+	/** @private */
+	get used() {
+		throw new Error("REMOVED");
+	}
+
+	// TODO webpack 5 remove
 	/**
 	 * @private
 	 * @param {*} v v
@@ -900,6 +900,12 @@ class ExportInfo {
 		throw new Error("REMOVED");
 	}
 
+	// TODO webpack 5 remove
+	/** @private */
+	get usedName() {
+		throw new Error("REMOVED");
+	}
+
 	get canMangle() {
 		switch (this.canMangleProvide) {
 			case undefined:
@@ -1473,6 +1479,7 @@ class ExportInfo {
 				if (list !== undefined) list.push(runtime);
 				else map.set(used, [runtime]);
 			}
+			// eslint-disable-next-line array-callback-return
 			const specificInfo = Array.from(map, ([used, runtimes]) => {
 				switch (used) {
 					case UsageState.NoInfo:

lib/ExternalModuleFactoryPlugin.js

@@ -25,6 +25,7 @@ const EMPTY_RESOLVE_OPTIONS = {};
 // TODO webpack 6 remove this
 const callDeprecatedExternals = util.deprecate(
 	(externalsFunction, context, request, cb) => {
+		// eslint-disable-next-line no-useless-call
 		externalsFunction.call(null, context, request, cb);
 	},
 	"The externals-function should be defined like ({context, request}, cb) => { ... }",