Skip to content

Commit a4b64d0

Browse files
committed
remove mentions of removed CreateBootstrap argument
1 parent ae14349 commit a4b64d0

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

documentation/Deploy-MSBuild.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
[Deploy-MSBuild](https://github.com/dotnet/msbuild/blob/deploy-msbuild/scripts/Deploy-MSBuild.ps1) is a way to conveniently take private bits and install them into Visual Studio (VS) for testing. To use it:
66

77
- If you haven't already, clone [MSBuild](https://github.com/dotnet/msbuild) and make the changes you want.
8-
- Build MSBuild with the changes you want using `build.cmd /p:CreateBootstrap=true`.
8+
- Build MSBuild with the changes you want using `build.cmd`.
99
- In an administrator powershell window, navigate to the msbuild folder.
1010
- Run `scripts\Deploy-MSBuild.ps1 -destination {destination} -configuration {configuration}`.
1111
- Specify the Bin folder of MSBuild in your VS install as the destination. This is somewhere like `"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin"`.

documentation/wiki/Building-Testing-and-Debugging-on-Full-Framework-MSBuild.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ Please see [Contributing Code](https://github.com/dotnet/msbuild/blob/main/docum
6363
To build projects using the MSBuild binaries from the repository, you first need to do a build which produces
6464
a "bootstrap" directory. The "bootstrap" directory mimics a Visual Studio installation by acquiring additional
6565
dependencies (Roslyn compilers, NuGet, etc.) from packages or from your local machine (e.g. props/targets
66-
from Visual Studio). This will happen by default when running `.\build.cmd`. The bootstrap can be disabled by running `.\build.cmd /p:CreateBootstrap=false`.
66+
from Visual Studio). This will happen by default when running `.\build.cmd`.
6767

6868
Now, just point `artifacts\bin\bootstrap\net472\MSBuild\Current\Bin\MSBuild.exe` at a project file.
6969

eng/cibuild_bootstrapped_msbuild.ps1

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ try {
6565

6666
if ($buildStage1)
6767
{
68-
& $PSScriptRoot\Common\Build.ps1 -restore -build -ci -msbuildEngine $msbuildEngine /p:CreateBootstrap=true @properties
68+
& $PSScriptRoot\Common\Build.ps1 -restore -build -ci -msbuildEngine $msbuildEngine @properties
6969
}
7070

7171
KillProcessesFromRepo
@@ -118,10 +118,10 @@ try {
118118
# - Turn off node reuse (so that bootstrapped MSBuild processes don't stay running and lock files)
119119
# - Create bootstrap environment as it's required when also running tests
120120
if ($onlyDocChanged) {
121-
& $PSScriptRoot\Common\Build.ps1 -restore -build -ci /p:CreateBootstrap=false /nr:false @properties
121+
& $PSScriptRoot\Common\Build.ps1 -restore -build -ci /nr:false @properties
122122
}
123123
else {
124-
& $PSScriptRoot\Common\Build.ps1 -restore -build -test -ci /p:CreateBootstrap=true /nr:false @properties
124+
& $PSScriptRoot\Common\Build.ps1 -restore -build -test -ci /nr:false @properties
125125
}
126126

127127
exit $lastExitCode

eng/cibuild_bootstrapped_msbuild.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ InitializeDotNetCli true
5151

5252
if [[ $build_stage1 == true ]];
5353
then
54-
/bin/bash "$ScriptRoot/common/build.sh" --restore --build --ci --configuration $configuration /p:CreateBootstrap=true $properties $extra_properties || exit $?
54+
/bin/bash "$ScriptRoot/common/build.sh" --restore --build --ci --configuration $configuration $properties $extra_properties || exit $?
5555
fi
5656

5757
bootstrapRoot="$Stage1Dir/bin/bootstrap"
@@ -84,8 +84,8 @@ export DOTNET_HOST_PATH="$_InitializeDotNetCli/dotnet"
8484
# - Create bootstrap environment as it's required when also running tests
8585
if [ $onlyDocChanged = 0 ]
8686
then
87-
. "$ScriptRoot/common/build.sh" --restore --build --test --ci --nodereuse false --configuration $configuration /p:CreateBootstrap=true $properties $extra_properties
87+
. "$ScriptRoot/common/build.sh" --restore --build --test --ci --nodereuse false --configuration $configuration $properties $extra_properties
8888

8989
else
90-
. "$ScriptRoot/common/build.sh" --restore --build --ci --nodereuse false --configuration $configuration /p:CreateBootstrap=false $properties $extra_properties
90+
. "$ScriptRoot/common/build.sh" --restore --build --ci --nodereuse false --configuration $configuration $properties $extra_properties
9191
fi

0 commit comments

Comments
 (0)