Skip to content

Fix fatal error when no cache provided in constructor #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2018
Merged

Fix fatal error when no cache provided in constructor #10

merged 1 commit into from
Apr 17, 2018

Conversation

krzysztof-pyrzyk-ah
Copy link
Contributor

Just a simple fix for a recently added lines.
If there is no $resultCache provided in constructor then this line will cause a fatal error as it will try to execute fetch() on null.

@JanDC JanDC merged commit 5038729 into JanDC:master Apr 17, 2018
@JanDC
Copy link
Owner

JanDC commented Apr 17, 2018

Thank you @krzysztof-pyrzyk-ah 👍
This was a major oversight 😄

@krzysztof-pyrzyk-ah krzysztof-pyrzyk-ah deleted the bugifx/fatal-error-when-no-result-cache-provided branch April 17, 2018 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysztof-pyrzyk-ah @JanDC