use iso date for decoding

Author: JanC

Sources/AVWXKit/Models/MetarDate.swift

@@ -11,30 +11,17 @@ import Foundation
 // encapsluates the metar string date in order to faciliate the JSON parsing
 struct MetarDate: Decodable {
     let date: Date
-    
     enum CodingKeys: String, CodingKey {
-        // todo
-//        "repr": "121756Z",
-//        "dt": "2019-04-12T17:56:00Z"
-        case time = "repr"
+        // "121756Z",
+        case repr = "repr"
+        // "2019-04-12T17:56:00Z"
+        case dt = "dt"
     }
     init(from decoder: Decoder) throws {
         // The metar time has a format 'ddHHmmZ' (e.g 130756Z)
         // So we need to append the current year and month (yyyy-MM) in order to parse the entire date back
 
         let container = try decoder.container(keyedBy: CodingKeys.self)
-        let metarString = try container.decode(String.self, forKey: .time)
-        
-        let now = Date()
-        let formatter = DateFormatter()
-        
-        formatter.dateFormat = "yyyy-MM"
-        
-        let thisMonth = formatter.string(from: now)
-        // yy-MM-ddHHmmZ
-        let metarFullDateString = thisMonth + "-" + metarString
-        
-        formatter.dateFormat = "yy-MM-ddHHmmZ"
-        date = formatter.date(from: metarFullDateString)!
+        date = try container.decode(Date.self, forKey: .dt)
     }
 }

Sources/AVWXKit/Network/AVWXClient.swift

@@ -59,6 +59,7 @@ public struct AVWXClient {
                 return
             }
             let decoder = JSONDecoder()
+            decoder.dateDecodingStrategy = .iso8601
             do {
                 let result = try decoder.decode(T.self, from: data)
                 completion(Result.success(result))

Tests/AVWXKitTests/DeserialisationSpecs.swift

@@ -15,6 +15,7 @@ import XCTest
 class DeserialisationSpecs: QuickSpec {
     override func spec() {
         let decoder = JSONDecoder()
+        decoder.dateDecodingStrategy = .iso8601
 
         describe("metar parsing") {
             context("given a valid metar") {