Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request New Feature] Set HookedEffectBuilder Retroactive & Preview text key #2

Open
Forwindzz opened this issue Nov 10, 2024 · 1 comment

Comments

@Forwindzz
Copy link

Hi, I want to add 2 api functions in class HookedEffectBuilder.
The api currently has HookedEffectBuilder.SetPreviewDescription, but does not have SetPreviewDescriptionKey. It might be a bit wired, compare to the api design of SetDescriptionKey and SetDescription
So, I would like to request two new api SetPreviewDescriptionKey and SetRetroactiveDescriptionKey in HookedEffectBuilder.

HookedEffectBuilder builder = new(PluginInfo.PLUGIN_GUID, cornerstoneName, cornerstoneIconPath);
builder.SetDescriptionKey($"description_key"); //invoke EffectBuilder<T>.SetDescriptionKey() method
builder.SetDisplayNameKey($"displayName_key");//invoke EffectBuilder<T>.SetDisplayNameKey() method
// API does not have these two methods :(
builder.SetPreviewDescriptionKey($"preview_key"); 
builder.SetRetroactiveDescriptionKey($"retroactive_key");
@Forwindzz Forwindzz changed the title [Require New Feature] Set HookedEffectBuilder Retroactive & Preview text key [Request New Feature] Set HookedEffectBuilder Retroactive & Preview text key Nov 10, 2024
@JamesVeug
Copy link
Owner

Ah they were definitely missed!
Added and ready for v2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants