Add Contract and Property Parameters to JsonConverter #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------- Added new JsonConverter abstract class JsonConverter2 with override to WriteJson with the Contract and Property parameters to allow features like TypeNameHandling.Auto handling to be added to the converter JsonSerializerInternalWriter.cs ------------------------------- Added a check to the JsonSerializerInternalWriter.SerializeConvertable function to check for the new JsonConverter2 base class and call the WriteJson override with the contract and property parameters. JsonConverter2Tests.cs ---------------------- Added a test case to test the serialization of a collection with multiple types and the TypeNameHandling.Auto logic added to a JsonConverter2 converter.
scptre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonConverter.cs
Added new JsonConverter abstract class JsonConverter2 with override to WriteJson with the Contract and Property parameters to allow features like TypeNameHandling.Auto handling to be added to the converter
JsonSerializerInternalWriter.cs
Added a check to the JsonSerializerInternalWriter.SerializeConvertable function to check for the new JsonConverter2 base class and call the WriteJson override with the contract and property parameters.
JsonConverter2Tests.cs
Added a test case to test the serialization of a collection with multiple types and the TypeNameHandling.Auto logic added to a JsonConverter2 converter.