After 6106 runs, process suddenly started failing due to worktree in use #1589
-
|
I've had an action running to deploy data from the YouTube API into my repository since last year with no issues, and it uses a very lightly modified version of the script shown in the full example from fetch-api-data-action After tweaks: This has been working flawlessly, with the permissions in my settings allowing read and write access for actions. But 4 hours ago, I got an email saying that it failed. Here are relevant logs: Note that I have looked at other issues in this repository where people have experienced exit code 128, tried all solutions mentioned in those issues, and it made no difference. The mentioned solutions were running with the GITHUB_TOKEN secret, and adding write permissions for content within the workflow file. Made no difference whether I had it or not, I'm curious as to why it spontaneously stopped working. My last commit before today was probably within the same month that I configured the action. |
Beta Was this translation helpful? Give feedback.
Replies: 5 comments 10 replies
-
|
I also encountered a similar problem. |
Beta Was this translation helpful? Give feedback.
-
|
It was still running normally two days ago. |
Beta Was this translation helpful? Give feedback.
-
|
Is this consistently failing, or have you tried running it since? The worktree still in use error makes me wonder if you need to add the concurrency property mentioned in the README. |
Beta Was this translation helpful? Give feedback.
-
|
It is consistently failing, even on the fresh repository, but I wonder if concurrency would still help. I'll mess around with it a little bit, and see if I can get something to work. |
Beta Was this translation helpful? Give feedback.
-
|
@xander2005 @JJLibra @JamesIves I was getting this error: I feel like the error might be something to do with the main branch, I was running the action on the main branch while deploying to the main branch of my other repository. I think that because the pipeline was running on my main branch and then the action is doing a checkout with -B flag to main in the target branch was causing some sort of conflict. The error for me occurred right after Common denominator appears to be using the branch name as "main". |
Beta Was this translation helpful? Give feedback.
-
|
Interesting- I wonder if something has changed. I'm noticing that my sponsor jobs are failing today also with the same error. Haven't actually updated anything in either action 🤔 These jobs use the branch dev, but in all cases that is the base branch. Wondering if there's a way to more gracefully handle this error, where we instead use the existing worktree if this step complains of one already existing. |
Beta Was this translation helpful? Give feedback.
-
|
@JamesIves @LukeHollandDev I have tried adding concurrency, but it didn't seem to change anything. Then, I ran the jobs on a different branch and it finished successfully. It's likely I'll have to stop the workflow from running on the main branch and set up a branch specially for running the jobs and push it to the main branch as a temporary fix. |
Beta Was this translation helpful? Give feedback.
-
|
Just adding more data if this helps debug the issue. I am using the following workflow for serversideup/docker-php. I also had this workflow working for about a year until today. Glad I was able to discover this thread. Here is my set up if this helps in any way: Workflow:name: Generate Sponsors README
on:
workflow_dispatch:
schedule:
- cron: 30 15 * * 0-6
jobs:
deploy:
runs-on: ubuntu-22.04
steps:
- name: Checkout 🛎️
uses: actions/checkout@v4
- name: Generate Sponsors 💖
uses: JamesIves/github-sponsors-readme-action@v1
with:
organization: true
minimum: 501
maximum: 5000
token: ${{ secrets.SPONSORS_README_ACTION_PERSONAL_ACCESS_TOKEN }}
marker: 'bronze'
template: '* [{{{ name }}}]({{{ url }}}) - {{{ login }}}'
file: 'README.md'
- name: Generate Sponsors 💖
uses: JamesIves/github-sponsors-readme-action@v1
with:
organization: true
maximum: 500
fallback: '<p align="center"><a href="/sponsors/serversideup"><img src="https://521public.s3.amazonaws.com/serversideup/sponsors/sponsor-empty-state.png" alt="Sponsors"></a></p>'
token: ${{ secrets.SPONSORS_README_ACTION_PERSONAL_ACCESS_TOKEN }}
marker: 'supporters'
template: '<a href="/{{{ login }}}"><img src="https://github.com/{{{ login }}}.png" width="40px" alt="{{{ login }}}" /></a> '
file: 'README.md'
- name: Deploy to GitHub Pages 🚀
uses: JamesIves/github-pages-deploy-action@v4
with:
branch: main
folder: '.'ErrorFull log: https://github.com/serversideup/docker-php/actions/runs/9131257941/job/25110053326
Thanks for your work @JamesIves! Much respect to you for maintaining this project 🤜💥🤛 |
Beta Was this translation helpful? Give feedback.
-
|
Working on debugging this, it seems like this is the problematic line: https://github.com/JamesIves/github-pages-deploy-action/blob/dev/src/worktree.ts#L43-L49 Wondering if this might be a side effect from actions/checkout, but need more time to debug. |
Beta Was this translation helpful? Give feedback.
-
|
Need to resolve tests, but have a potential fix for this here: #1591 Will try and get this released and validated tomorrow morning. Sorry for the hold up. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you so much @JamesIves ! It works. |
Beta Was this translation helpful? Give feedback.
-
|
I can also confirm that this works. I appreciate all that you've done, I'll keep an eye out for when the fix is fully released in case I have to make any more changes to the workflow file. |
Beta Was this translation helpful? Give feedback.
-
|
This has been released in v4.6.1. If you're referencing Enjoy your weekend, and thank you for your patience! If you encounter any further problems please raise an issue. |
Beta Was this translation helpful? Give feedback.
-
I believe the change that was causing this is this one: https://github.com/git/git/blob/v2.45.0/Documentation/RelNotes/2.44.0.txt#L6-L8 If a branch named X was checked out by actions/checkout, and github-pages-deploy-action was asked to deploy to the same branch X, it would attempt to create a worktree with the same branch name, which used to silently reset the branch before git 2.44 (rendering the original worktree possibly dirty) but isn't allowed any more. |
Beta Was this translation helpful? Give feedback.
This has been released in v4.6.1. If you're referencing
@v4directly your workflows should now work.Enjoy your weekend, and thank you for your patience! If you encounter any further problems please raise an issue.