-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node v20 support #7
Comments
So basically
Evil-dns just returns a single object regardless, so this would have been an existing bug for anything calling with However in Node 20 this got more visible, as the core net code now includes In the end the answer is to check for that option and return as an array if needed. Going from: return process.nextTick(() => callback(null, entry.ip, entry.family)); To: if (typeof(options) === 'object' && options.all) {
return process.nextTick(() => callback(null, [{address: entry.ip, family: entry.family}]));
}
else return process.nextTick(() => callback(null, entry.ip, entry.family)); |
Thanks for the PR @jpage-godaddy and sorry for the late reply, I'm currently away checking out colleges w/ my daughter. |
Sadly this module no longer works in Node v20+. Going to take a look but seems core dns lookup must have been reworked.
The text was updated successfully, but these errors were encountered: