Skip to content
This repository has been archived by the owner on Jun 5, 2022. It is now read-only.

withPreview attribute defaults to false #174

Open
yehee opened this issue Jun 16, 2020 · 2 comments
Open

withPreview attribute defaults to false #174

yehee opened this issue Jun 16, 2020 · 2 comments

Comments

@yehee
Copy link

yehee commented Jun 16, 2020

Hi! I've used this package for my React project and it's been great! I was wondering if there is a reason behind having withPreview attribute defaults to false. When I initially started using it, the image preview was not showing as mentioned in #48. I realized that the attribute needs to be set to true in order for it to work after stumbling upon that issue.

Here is where its default gets set to false. Would it make sense that this value is set to true instead? If there has been a discussion over such topic already, I'd love to read about it as well. Thank you!

@JakeHartnell
Copy link
Owner

Not sure it's really been discussed before. Does anyone feel strongly about this?

@verluci
Copy link

verluci commented Jun 25, 2020

I can't imagine a lot of people want withPreview to be false because the user doesn't get feedback about the image being uploaded or not. I'd say it should default to true

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants