Skip to content

Conversation

@baptistegrimaud
Copy link
Contributor

@baptistegrimaud baptistegrimaud commented Sep 19, 2024

JIRA

https://jira.jahia.org/browse/BACKLOG-22972

Description

Update the packaging and deployment scripts to treat SNAPSHOTS artifacts differently, by appending a -SNAPSHOT prefix to the filename.
Also, refactor the logic to compute the package filename.
Related to https://github.com/Jahia/npm-modules-engine/pull/183.

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@baptistegrimaud baptistegrimaud force-pushed the BACKLOG-22972-adapt-scripting-to-support-snapshot branch from 3ddb30e to 51f1677 Compare September 19, 2024 10:00
@baptistegrimaud baptistegrimaud marked this pull request as ready for review September 19, 2024 10:49
@baptistegrimaud baptistegrimaud force-pushed the BACKLOG-22972-adapt-scripting-to-support-snapshot branch from 51f1677 to 8620161 Compare September 19, 2024 13:25
@baptistegrimaud baptistegrimaud requested a review from a team September 19, 2024 13:26
jkevan
jkevan previously approved these changes Sep 24, 2024
@baptistegrimaud baptistegrimaud force-pushed the BACKLOG-22972-adapt-scripting-to-support-snapshot branch from 8620161 to d081b97 Compare September 25, 2024 09:20
@baptistegrimaud baptistegrimaud merged commit 83edcc8 into master Sep 25, 2024
2 checks passed
@baptistegrimaud baptistegrimaud deleted the BACKLOG-22972-adapt-scripting-to-support-snapshot branch September 25, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants