BACKLOG-21054: Fix legacy picker for vanity urls #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkevan
previously approved these changes
May 30, 2023
tdraier
previously approved these changes
May 30, 2023
tdraier
reviewed
May 30, 2023
tdraier
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/BACKLOG-21054
All null checks are now returning undefined after data-helper upgrade, so we have to adjust the checks to falsy values instead.
Also openPaths missing on init is now causing issue on cached query and throwing error. Needed to add a default value to fix.Edit: Not needed as this was being set here: https://github.com/Jahia/javascript-components/blob/master/packages/data-helper/src/legacy/Picker.tsx#L165 but was being blocked by the null checks issue which was already fixed.